Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(132)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1212373003: Devtools [LayouEditor]: Show label with size info (Closed)

Created:
5 years, 6 months ago by sergeyv
Modified:
5 years, 5 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Devtools [LayouEditor]: Show label with size info BUG=501896 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=198123

Patch Set 1 #

Patch Set 2 : show real data #

Patch Set 3 : show while dragging #

Total comments: 10

Patch Set 4 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+178 lines, -34 lines) Patch
M Source/core/inspector/InspectorInstrumentation.idl View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlayPage.html View 1 2 3 10 chunks +137 lines, -16 lines 0 comments Download
M Source/core/inspector/InspectorPageAgent.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorPageAgent.cpp View 1 2 3 1 chunk +0 lines, -6 lines 0 comments Download
M Source/core/inspector/LayoutEditor.h View 1 2 chunks +3 lines, -0 lines 0 comments Download
M Source/core/inspector/LayoutEditor.cpp View 1 2 3 4 chunks +35 lines, -8 lines 0 comments Download
M Source/web/InspectorOverlayImpl.cpp View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download

Depends on Patchset:

Issue 1212373003 Patch 1

Messages

Total messages: 23 (9 generated)
sergeyv
5 years, 5 months ago (2015-06-29 14:46:07 UTC) #2
dgozman
Let's follow up with overlay page rewrite. https://codereview.chromium.org/1212373003/diff/40001/Source/core/inspector/InspectorOverlayPage.html File Source/core/inspector/InspectorOverlayPage.html (right): https://codereview.chromium.org/1212373003/diff/40001/Source/core/inspector/InspectorOverlayPage.html#newcode644 Source/core/inspector/InspectorOverlayPage.html:644: resetCanvas(labelsCanvas); Let's ...
5 years, 5 months ago (2015-06-29 15:18:35 UTC) #3
sergeyv
https://codereview.chromium.org/1212373003/diff/40001/Source/core/inspector/InspectorOverlayPage.html File Source/core/inspector/InspectorOverlayPage.html (right): https://codereview.chromium.org/1212373003/diff/40001/Source/core/inspector/InspectorOverlayPage.html#newcode644 Source/core/inspector/InspectorOverlayPage.html:644: resetCanvas(labelsCanvas); On 2015/06/29 15:18:35, dgozman wrote: > Let's remove ...
5 years, 5 months ago (2015-06-29 16:30:33 UTC) #4
dgozman
lgtm
5 years, 5 months ago (2015-06-29 16:41:42 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212373003/60001
5 years, 5 months ago (2015-06-29 16:42:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: blink_presubmit on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/blink_presubmit/builds/36605)
5 years, 5 months ago (2015-06-29 16:47:28 UTC) #9
sergeyv
@pfeldman Can you please take a look? I need a lgtm for Source/web/
5 years, 5 months ago (2015-06-30 08:32:23 UTC) #11
pfeldman
lgtm
5 years, 5 months ago (2015-06-30 12:31:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212373003/60001
5 years, 5 months ago (2015-06-30 12:34:14 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68787)
5 years, 5 months ago (2015-06-30 15:35:05 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212373003/60001
5 years, 5 months ago (2015-06-30 16:40:11 UTC) #18
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/68834)
5 years, 5 months ago (2015-06-30 19:19:49 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212373003/60001
5 years, 5 months ago (2015-07-01 07:52:37 UTC) #22
commit-bot: I haz the power
5 years, 5 months ago (2015-07-01 08:29:43 UTC) #23
Message was sent while issue was closed. 
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198123

Powered by Google App Engine
This is Rietveld 408576698