Devtools [LayouEditor]: Show label with size info

Source/core/inspector/LayoutEditor.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "config.h"
 #include "core/inspector/LayoutEditor.h"
 
 #include "core/css/CSSComputedStyleDeclaration.h"
 #include "core/css/CSSPrimitiveValue.h"
 #include "core/frame/FrameView.h"
 #include "core/inspector/InspectorCSSAgent.h"
 #include "core/layout/LayoutBox.h"
 #include "core/layout/LayoutInline.h"
 #include "core/layout/LayoutObject.h"
 #include "platform/JSONValues.h"
 
 namespace blink {
 
 namespace {
 
-PassRefPtr<JSONObject> createAnchor(float x, float y, const String& propertyName, FloatPoint deltaVector)
+PassRefPtr<JSONObject> createAnchor(float x, float y, const String& propertyName, FloatPoint deltaVector, PassRefPtr<JSONObject> valueDescription)
 {
     RefPtr<JSONObject> object = JSONObject::create();
     object->setNumber("x", x);
     object->setNumber("y", y);
     object->setString("propertyName", propertyName);
 
     RefPtr<JSONObject> deltaVectorJSON = JSONObject::create();
     deltaVectorJSON->setNumber("x", deltaVector.x());
     deltaVectorJSON->setNumber("y", deltaVector.y());
     object->setObject("deltaVector", deltaVectorJSON.release());
-
+    object->setObject("propertyValue", valueDescription);
     return object.release();
 }
 
 void contentsQuadToViewport(const FrameView* view, FloatQuad& quad)
 {
     quad.setP1(view->contentsToViewport(roundedIntPoint(quad.p1())));
     quad.setP2(view->contentsToViewport(roundedIntPoint(quad.p2())));
     quad.setP3(view->contentsToViewport(roundedIntPoint(quad.p3())));
     quad.setP4(view->contentsToViewport(roundedIntPoint(quad.p4())));
 }
@@ skipping 70 matching lines @@
     float xLeft = (padding.p1().x() + padding.p4().x()) / 2;
     float yLeft = (padding.p1().y() + padding.p4().y()) / 2;
     FloatPoint orthoLeft = orthogonalVector(padding.p4(), padding.p1(), FloatPoint(-1, 0));
 
     float xRight = (padding.p2().x() + padding.p3().x()) / 2;
     float yRight = (padding.p2().y() + padding.p3().y()) / 2;
     FloatPoint orthoRight = orthogonalVector(padding.p2(), padding.p3(), FloatPoint(1, 0));
 
     RefPtr<JSONObject> object = JSONObject::create();
     RefPtr<JSONArray> anchors = JSONArray::create();
-    anchors->pushObject(createAnchor(xLeft, yLeft, "padding-left", orthoLeft));
-    anchors->pushObject(createAnchor(xRight, yRight, "padding-right", orthoRight));
+
+    RefPtr<JSONObject> paddingLeftDescription = createValueDescription("padding-left");
+    if (paddingLeftDescription)
+        anchors->pushObject(createAnchor(xLeft, yLeft, "padding-left", orthoLeft, paddingLeftDescription.release()));
+
+    RefPtr<JSONObject> paddingRightDescription = createValueDescription("padding-right");
+    if (paddingRightDescription)
+        anchors->pushObject(createAnchor(xRight, yRight, "padding-right", orthoRight, paddingRightDescription.release()));
+
     object->setArray("anchors", anchors.release());
-
     return object.release();
 }
 
+RefPtrWillBeRawPtr<CSSPrimitiveValue> LayoutEditor::getPropertyCSSValue(CSSPropertyID property) const
+{
+    RefPtrWillBeRawPtr<CSSComputedStyleDeclaration> computedStyleInfo = CSSComputedStyleDeclaration::create(m_node, true);
+    RefPtrWillBeRawPtr<CSSValue> cssValue = computedStyleInfo->getPropertyCSSValue(property);
+    if (!cssValue->isPrimitiveValue())
+        return nullptr;
+
+    return toCSSPrimitiveValue(cssValue.get());
+}
+
+PassRefPtr<JSONObject> LayoutEditor::createValueDescription(const String& propertyName) const
+{
+    RefPtrWillBeRawPtr<CSSPrimitiveValue> cssValue = getPropertyCSSValue(cssPropertyID(propertyName));
+    if (!cssValue)
+        return nullptr;
+
+    RefPtr<JSONObject> object = JSONObject::create();
+    object->setNumber("value", cssValue->getFloatValue());
+    object->setString("unit", "px");
+    return object.release();
+}
+
 void LayoutEditor::overlayStartedPropertyChange(const String& anchorName)
 {
     m_changingProperty = cssPropertyID(anchorName);
     if (!m_node || !m_changingProperty)
         return;
 
-    RefPtrWillBeRawPtr<CSSComputedStyleDeclaration> computedStyleInfo = CSSComputedStyleDeclaration::create(m_node, true);
-    RefPtrWillBeRawPtr<CSSValue> cssValue = computedStyleInfo->getPropertyCSSValue(m_changingProperty);
-    if (!cssValue->isPrimitiveValue()) {
+    RefPtrWillBeRawPtr<CSSPrimitiveValue> cssValue = getPropertyCSSValue(m_changingProperty);
+    if (!cssValue) {
         m_changingProperty = CSSPropertyInvalid;
         return;
     }
 
-    m_propertyInitialValue = toCSSPrimitiveValue(cssValue.get())->getFloatValue();
+    m_propertyInitialValue = cssValue->getFloatValue();
 }
 
 void LayoutEditor::overlayPropertyChanged(float cssDelta)
 {
     if (m_changingProperty)
         m_cssAgent->setCSSPropertyValue(m_node.get(), m_changingProperty, cssDelta + m_propertyInitialValue);
 }
 
 void LayoutEditor::overlayEndedPropertyChange()
 {
     m_changingProperty = CSSPropertyInvalid;
     m_propertyInitialValue = 0;
 }
 
 } // namespace blink