Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(539)

Issue 1212003003: Convert sbox_validation_tests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 3 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Nico
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@4_sbox_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert sbox_validation_tests to run exclusively on Swarming 0 configs already ran on Swarming 7 used to run locally and were converted: - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert sbox_validation_tests R=cpu@chromium.org,thakis@chromium.org BUG=98637 Committed: https://crrev.com/59ef9be12ee89bc452b83bec060d90514dc86c66 Cr-Commit-Position: refs/heads/master@{#338434}

Patch Set 1 #

Patch Set 2 : Include wow_helper only on 32 bits build #

Total comments: 2

Patch Set 3 : improved #

Patch Set 4 : Fix rebase error #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, --1 lines) Patch
M build/gn_migration.gypi View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
A + sandbox/sbox_validation_tests.isolate View 0 chunks +-1 lines, --1 lines 1 comment Download
M sandbox/win/sandbox_win.gypi View 1 2 3 1 chunk +13 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 12 (3 generated)
M-A Ruel
5 years, 5 months ago (2015-07-03 20:13:07 UTC) #1
Nico
lgtm (no idea what wow_helper is, but I guess it's there for some reason) https://codereview.chromium.org/1212003003/diff/20001/sandbox/sbox_validation_tests.isolate ...
5 years, 5 months ago (2015-07-03 21:11:56 UTC) #2
M-A Ruel
On 2015/07/03 21:11:56, Nico wrote: > lgtm > > (no idea what wow_helper is, but ...
5 years, 5 months ago (2015-07-06 18:28:02 UTC) #3
M-A Ruel
Justin -> Carlos
5 years, 5 months ago (2015-07-06 18:28:30 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm note that your 3 CLs touch build/gn_migration.gypi in a way that needs a specific ...
5 years, 5 months ago (2015-07-07 17:55:40 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1212003003/60001
5 years, 5 months ago (2015-07-11 04:03:19 UTC) #9
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 5 months ago (2015-07-11 05:16:06 UTC) #10
commit-bot: I haz the power
Patchset 4 (id:??) landed as https://crrev.com/59ef9be12ee89bc452b83bec060d90514dc86c66 Cr-Commit-Position: refs/heads/master@{#338434}
5 years, 5 months ago (2015-07-11 05:17:01 UTC) #11
M-A Ruel
5 years, 3 months ago (2015-09-02 19:18:48 UTC) #12
Message was sent while issue was closed.
https://codereview.chromium.org/1212003003/diff/60001/sandbox/sbox_validation...
File sandbox/sbox_validation_tests.isolate (right):

https://codereview.chromium.org/1212003003/diff/60001/sandbox/sbox_validation...
sandbox/sbox_validation_tests.isolate:13: '<(PRODUCT_DIR)/sbox_unittests.exe',
Let's play at Spot The Error.

Powered by Google App Engine
This is Rietveld 408576698