Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Issue 1219403002: Convert sbox_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
Reviewers:
cpu_(ooo_6.6-7.5), Nico
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@3_sbox_integration_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert sbox_unittests to run exclusively on Swarming 0 configs already ran on Swarming 7 used to run locally and were converted: - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert sbox_unittests R=cpu@chromium.org,thakis@chromium.org BUG=98637 Committed: https://crrev.com/a08b9010d29c125d347f46bb8790fc7881d9f459 Cr-Commit-Position: refs/heads/master@{#338418}

Patch Set 1 #

Patch Set 2 : Include wow_helper only on 32 bits build #

Total comments: 4

Patch Set 3 : improved #

Patch Set 4 : Rebase #

Patch Set 5 : Fix rebase error #

Unified diffs Side-by-side diffs Delta from patch set Stats (+37 lines, -2 lines) Patch
M build/gn_migration.gypi View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
A + sandbox/sbox_unittests.isolate View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M sandbox/win/sandbox_win.gypi View 1 2 3 4 1 chunk +13 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 1 2 3 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 30 (14 generated)
M-A Ruel
5 years, 5 months ago (2015-07-03 20:13:05 UTC) #1
Nico
lgtm https://codereview.chromium.org/1219403002/diff/20001/sandbox/sbox_unittests.isolate File sandbox/sbox_unittests.isolate (right): https://codereview.chromium.org/1219403002/diff/20001/sandbox/sbox_unittests.isolate#newcode1 sandbox/sbox_unittests.isolate:1: # Copyright 2014 The Chromium Authors. All rights ...
5 years, 5 months ago (2015-07-03 21:11:10 UTC) #2
M-A Ruel
https://codereview.chromium.org/1219403002/diff/20001/sandbox/sbox_unittests.isolate File sandbox/sbox_unittests.isolate (right): https://codereview.chromium.org/1219403002/diff/20001/sandbox/sbox_unittests.isolate#newcode1 sandbox/sbox_unittests.isolate:1: # Copyright 2014 The Chromium Authors. All rights reserved. ...
5 years, 5 months ago (2015-07-06 18:26:19 UTC) #3
M-A Ruel
Justin -> Carlos
5 years, 5 months ago (2015-07-06 18:28:50 UTC) #5
cpu_(ooo_6.6-7.5)
this should be fine. As for the dependency on base I have come to regret ...
5 years, 5 months ago (2015-07-07 17:45:44 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219403002/40001
5 years, 5 months ago (2015-07-07 17:47:30 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/42487) ios_rel_device_ninja on tryserver.chromium.mac (JOB_FAILED, ...
5 years, 5 months ago (2015-07-07 17:52:04 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219403002/40001
5 years, 5 months ago (2015-07-10 21:37:54 UTC) #13
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/94803) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 21:45:12 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219403002/60001
5 years, 5 months ago (2015-07-10 21:48:21 UTC) #19
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/94813) android_clang_dbg_recipe on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 21:55:22 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219403002/60001
5 years, 5 months ago (2015-07-10 22:04:36 UTC) #23
commit-bot: I haz the power
Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile_dbg/builds/35333) cast_shell_android on tryserver.chromium.linux (JOB_FAILED, ...
5 years, 5 months ago (2015-07-10 22:12:00 UTC) #25
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1219403002/80001
5 years, 5 months ago (2015-07-10 22:56:18 UTC) #28
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-07-11 01:15:21 UTC) #29
commit-bot: I haz the power
5 years, 5 months ago (2015-07-11 01:17:01 UTC) #30
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/a08b9010d29c125d347f46bb8790fc7881d9f459
Cr-Commit-Position: refs/heads/master@{#338418}

Powered by Google App Engine
This is Rietveld 408576698