Source/core/rendering/svg/SVGRenderTreeAsText.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Unified Diff: Source/core/rendering/svg/SVGRenderTreeAsText.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/rendering/svg/ReferenceFilterBuilder.cpp ('K') | « Source/core/rendering/svg/RenderSVGResourceFilter.cpp ('k') | Source/core/rendering/svg/SVGResources.cpp » ('j') | Source/core/rendering/svg/SVGResources.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/rendering/svg/SVGRenderTreeAsText.cpp

diff --git a/Source/core/rendering/svg/SVGRenderTreeAsText.cpp b/Source/core/rendering/svg/SVGRenderTreeAsText.cpp

index b92e9b998333be7322ad89083043f6b004e4a2bf..74afbf771bbd1f151d90226818147aee5c061120 100644

--- a/Source/core/rendering/svg/SVGRenderTreeAsText.cpp

+++ b/Source/core/rendering/svg/SVGRenderTreeAsText.cpp

@@ -626,7 +626,7 @@ void writeResources(TextStream& ts, const RenderObject& object, int indent)

// For now leave the DRT output as is, but later on we should change this so cycles are properly ignored in the DRT output.

RenderObject& renderer = const_cast<RenderObject&>(object);

if (!svgStyle->maskerResource().isEmpty()) {

- if (RenderSVGResourceMasker* masker = getRenderSVGResourceById<RenderSVGResourceMasker>(object.document(), svgStyle->maskerResource())) {

+ if (RenderSVGResourceMasker* masker = getRenderSVGResourceById<RenderSVGResourceMasker>(object.document(), AtomicString(svgStyle->maskerResource()))) {

eseidel 2014/01/01 01:42:07 I should have made all of these AtomicSTrings n SV

Inactive 2014/01/01 16:12:59 Done.

writeIndent(ts, indent);

ts << " ";

writeNameAndQuotedValue(ts, "masker", svgStyle->maskerResource());

@@ -636,7 +636,7 @@ void writeResources(TextStream& ts, const RenderObject& object, int indent)

}

if (!svgStyle->clipperResource().isEmpty()) {

- if (RenderSVGResourceClipper* clipper = getRenderSVGResourceById<RenderSVGResourceClipper>(object.document(), svgStyle->clipperResource())) {

+ if (RenderSVGResourceClipper* clipper = getRenderSVGResourceById<RenderSVGResourceClipper>(object.document(), AtomicString(svgStyle->clipperResource()))) {

writeIndent(ts, indent);

ts << " ";

writeNameAndQuotedValue(ts, "clipPath", svgStyle->clipperResource());

@@ -646,7 +646,7 @@ void writeResources(TextStream& ts, const RenderObject& object, int indent)

}

if (!svgStyle->filterResource().isEmpty()) {

- if (RenderSVGResourceFilter* filter = getRenderSVGResourceById<RenderSVGResourceFilter>(object.document(), svgStyle->filterResource())) {

+ if (RenderSVGResourceFilter* filter = getRenderSVGResourceById<RenderSVGResourceFilter>(object.document(), AtomicString(svgStyle->filterResource()))) {

writeIndent(ts, indent);

ts << " ";

writeNameAndQuotedValue(ts, "filter", svgStyle->filterResource());