Source/core/rendering/svg/SVGResources.cpp - Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGResources.cpp

Issue 121173004: Make calls to AtomicString(const String&) explicit in svg/ (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years, 12 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/rendering/svg/SVGResources.cpp

diff --git a/Source/core/rendering/svg/SVGResources.cpp b/Source/core/rendering/svg/SVGResources.cpp

index b9c6f5903d326caebafe9a0c28e0e0cd7079ed65..fda064fc442688ec7d9867abde1c870c7e0954d4 100644

--- a/Source/core/rendering/svg/SVGResources.cpp

+++ b/Source/core/rendering/svg/SVGResources.cpp

@@ -172,7 +172,7 @@ static inline RenderSVGResourceContainer* paintingResourceFromSVGPaint(Document&

if (!svgPaintTypeHasURL(paintType))

return 0;

- id = SVGURIReference::fragmentIdentifierFromIRIString(paintUri, document);

+ id = AtomicString(SVGURIReference::fragmentIdentifierFromIRIString(paintUri, document));

eseidel 2014/01/01 01:42:07 Again, fragments seem to always ben AtomicStrings.

Inactive 2014/01/01 16:12:59 Done.

RenderSVGResourceContainer* container = getRenderSVGResourceContainerById(document, id);

if (!container) {

hasPendingResource = true;

« Source/core/rendering/svg/SVGRenderTreeAsText.cpp ('K') | « Source/core/rendering/svg/SVGRenderTreeAsText.cpp ('k') | Source/core/svg/SVGAElement.cpp » ('j') | no next file with comments »