Make calls to AtomicString(const String&) explicit in svg/

Source/core/rendering/svg/ReferenceFilterBuilder.cpp

Index: Source/core/rendering/svg/ReferenceFilterBuilder.cpp
diff --git a/Source/core/rendering/svg/ReferenceFilterBuilder.cpp b/Source/core/rendering/svg/ReferenceFilterBuilder.cpp
index 8c0a5c517a4efdcff78d1ae1fb48511b7340beca..7f03db2f1e75defab798c320bf1960acff56aa4e 100644
--- a/Source/core/rendering/svg/ReferenceFilterBuilder.cpp
+++ b/Source/core/rendering/svg/ReferenceFilterBuilder.cpp
@@ -82,8 +82,7 @@ static bool getSVGElementColorSpace(SVGElement* svgElement, ColorSpace& cs)
         eColorInterpolation = svgStyle->colorInterpolationFilters();
     } else {
         // Otherwise, use the slow path by using string comparison (used by external svg files)
-        RefPtr<CSSValue> cssValue = svgElement->getPresentationAttribute(
-            SVGNames::color_interpolation_filtersAttr.toString());
+        RefPtr<CSSValue> cssValue = svgElement->getPresentationAttribute(AtomicString(SVGNames::color_interpolation_filtersAttr.toString()));

[eseidel, 2014/01/01 01:42:07]

Wat?

[Inactive, 2014/01/01 16:12:59]

We have a QualifiedName object and we need to get an AtomicString. While the
QualifiedName members (prefix, localName) are stored as AtomicStrings, the
QualifiedName::toString() method concatenates them and returns a String. If this
is a common use case, we might want to add a QualifiedName::toAtomicString()
method. Based on the code I have updated, I am not convinced this is common
though.

         if (cssValue.get() && cssValue->isPrimitiveValue()) {
             const CSSPrimitiveValue& primitiveValue = *((CSSPrimitiveValue*)cssValue.get());
             eColorInterpolation = (EColorInterpolation)primitiveValue;
@@ -126,12 +125,12 @@ PassRefPtr<FilterEffect> ReferenceFilterBuilder::build(Filter* parentFilter, Ren
     if (!document)
         return 0;
 
-    Element* filter = document->getElementById(filterOperation->fragment());
+    Element* filter = document->getElementById(AtomicString(filterOperation->fragment()));

[eseidel, 2014/01/01 01:42:07]

It seems fragment wants to be an AtomicString?

[Inactive, 2014/01/01 16:12:59]

Done.

 
     if (!filter) {
         // Although we did not find the referenced filter, it might exist later
         // in the document
-        document->accessSVGExtensions()->addPendingResource(filterOperation->fragment(), toElement(renderer->node()));
+        document->accessSVGExtensions()->addPendingResource(AtomicString(filterOperation->fragment()), toElement(renderer->node()));
         return 0;
     }
 
@@ -169,7 +168,7 @@ PassRefPtr<FilterEffect> ReferenceFilterBuilder::build(Filter* parentFilter, Ren
         ColorSpace colorSpace = filterColorSpace;
         if (useFilterColorSpace || getSVGElementColorSpace(effectElement, colorSpace))
             effect->setOperatingColorSpace(colorSpace);
-        builder->add(effectElement->resultCurrentValue(), effect);
+        builder->add(AtomicString(effectElement->resultCurrentValue()), effect);
     }
     return builder->lastEffect();
 }