Cleanup CandidateWindowView.

Cleanup CandidateWindowView.

- moves the implementation of CandidateView as a separate cc file.
- CandidateView is now a button to reduce the click handling.
- introduces canceling drag logic over CandidateViews
- CandidateWindowView is now a BubbleDelegateView
- HidableArea is removed. It's not used anymore.
- removes complex GridLayout logic and use BoxLayout.

BUG=325813
R=komatsu@chromium.org
TEST=unit_tests pass, manually check

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243106

[Hiro Komatsu, 2013-12-27 07:13:34]

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
(right):

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc:45:
void CandidateWindowControllerImpl::CreateView() {
Let's delete this function.

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc:234:
InitCandidateWindowView();
When the only composition text  is updated, the candidate window should not be
shown.

How about separating preedit_view from candidate_window_view?  In this case, I
prefer "composition" instead of "preedit".

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/candidate_window_view.cc (right):

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/candidate_window_view.cc:258:
auxiliary_text_->SetBorder(InformationTextArea::TOP);
Please double check if TOP and BOTTOM are correct or opposite.

[Jun Mukai, 2013-12-27 11:01:12]

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc
(right):

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc:45:
void CandidateWindowControllerImpl::CreateView() {
On 2013/12/27 07:13:34, Hiro Komatsu (OOO Dec19 - 25) wrote:
> Let's delete this function.

Done.

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc:234:
InitCandidateWindowView();
On 2013/12/27 07:13:34, Hiro Komatsu (OOO Dec19 - 25) wrote:
> When the only composition text  is updated, the candidate window should not be
> shown.
> 
> How about separating preedit_view from candidate_window_view?  In this case, I
> prefer "composition" instead of "preedit".

This is only for the preedit in the candidate window.

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
File chrome/browser/chromeos/input_method/candidate_window_view.cc (right):

https://codereview.chromium.org/121163003/diff/30001/chrome/browser/chromeos/...
chrome/browser/chromeos/input_method/candidate_window_view.cc:258:
auxiliary_text_->SetBorder(InformationTextArea::TOP);
On 2013/12/27 07:13:34, Hiro Komatsu (OOO Dec19 - 25) wrote:
> Please double check if TOP and BOTTOM are correct or opposite.

This is correct. When vertical, the aux text will appear at the bottom, so the
border should appear only at the top, and vice versa.

[Jun Mukai, 2014-01-06 01:21:39]

ping?

[Hiro Komatsu, 2014-01-06 05:00:11]

lgtm

[commit-bot: I haz the power, 2014-01-06 05:21:31]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/121163003/160001

[commit-bot: I haz the power, 2014-01-06 09:46:11]

Retried try job too often on win_rel for step(s) browser_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&nu...

[commit-bot: I haz the power, 2014-01-06 13:46:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/121163003/160001

[commit-bot: I haz the power, 2014-01-06 17:03:27]

Change committed as 243106