Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5034)

Unified Diff: chrome/browser/chromeos/input_method/candidate_window_controller_impl.h

Issue 121163003: Cleanup CandidateWindowView. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: fix Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/chromeos/input_method/candidate_window_controller_impl.h
diff --git a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.h b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.h
index 5356bb4323c87938150667e1516ce5eca5417d98..539652577dd2e02ac0d86003a4ffe586cb57d703 100644
--- a/chrome/browser/chromeos/input_method/candidate_window_controller_impl.h
+++ b/chrome/browser/chromeos/input_method/candidate_window_controller_impl.h
@@ -55,8 +55,6 @@ class CandidateWindowControllerImpl
private:
// CandidateWindowView::Observer implementation.
virtual void OnCandidateCommitted(int index) OVERRIDE;
- virtual void OnCandidateWindowOpened() OVERRIDE;
- virtual void OnCandidateWindowClosed() OVERRIDE;
// views::WidgetObserver implementation.
virtual void OnWidgetClosing(views::Widget* widget) OVERRIDE;
@@ -70,19 +68,17 @@ class CandidateWindowControllerImpl
unsigned int cursor, bool visible) OVERRIDE;
virtual void FocusStateChanged(bool is_focused) OVERRIDE;
- // Creates the candidate window view.
- void CreateView();
+ void InitCandidateWindowView();
// The candidate window view.
CandidateWindowView* candidate_window_view_;
- // This is the outer frame of the candidate window view. The frame will
- // own |candidate_window_|.
- scoped_ptr<views::Widget> frame_;
-
// This is the outer frame of the infolist window view. Owned by the widget.
InfolistWindow* infolist_window_;
+ gfx::Rect cursor_bounds_;
+ gfx::Rect composition_head_;
+
// This is the controller of the IME mode indicator.
scoped_ptr<ModeIndicatorController> mode_indicator_controller_;

Powered by Google App Engine
This is Rietveld 408576698