Cleanup CandidateWindowView.

chrome/browser/chromeos/input_method/candidate_window_controller_impl.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/input_method/candidate_window_controller_impl.h"
 
 #include <string>
 #include <vector>
 
 #include "ash/shell.h"
@@ skipping 18 matching lines @@
 
 CandidateWindowControllerImpl::CandidateWindowControllerImpl()
     : candidate_window_view_(NULL),
       infolist_window_(NULL) {
   IBusBridge::Get()->SetCandidateWindowHandler(this);
   CreateView();
 }
 
 CandidateWindowControllerImpl::~CandidateWindowControllerImpl() {
   IBusBridge::Get()->SetCandidateWindowHandler(NULL);
-  candidate_window_view_->RemoveObserver(this);
+  if (candidate_window_view_) {
+    candidate_window_view_->RemoveObserver(this);
+    candidate_window_view_->GetWidget()->RemoveObserver(this);
+  }
 }
 
 void CandidateWindowControllerImpl::CreateView() {

[Hiro Komatsu, 2013/12/27 07:13:34]

Let's delete this function.

[Jun Mukai, 2013/12/27 11:01:13]

Done.

-  // Create a non-decorated frame.
-  frame_.reset(new views::Widget);
-  // The size is initially zero.
-  views::Widget::InitParams params(views::Widget::InitParams::TYPE_POPUP);
-  // |frame_| is owned by controller impl so
-  // they should use WIDGET_OWNS_NATIVE_WIDGET ownership.
-  params.ownership = views::Widget::InitParams::WIDGET_OWNS_NATIVE_WIDGET;
-  // Show the candidate window always on top
-  params.parent = ash::Shell::GetContainer(
-      ash::Shell::GetTargetRootWindow(),
-      ash::internal::kShellWindowId_InputMethodContainer);
-  frame_->Init(params);
-
-  views::corewm::SetWindowVisibilityAnimationType(
-      frame_->GetNativeView(),
-      views::corewm::WINDOW_VISIBILITY_ANIMATION_TYPE_FADE);
-
-  // Create the candidate window.
-  candidate_window_view_ = new CandidateWindowView(frame_.get());
-  candidate_window_view_->Init();
-  candidate_window_view_->AddObserver(this);
-
-  frame_->SetContentsView(candidate_window_view_);
-
   // Create the mode indicator controller.
   mode_indicator_controller_.reset(
       new ModeIndicatorController(InputMethodManager::Get()));
 }
 
+void CandidateWindowControllerImpl::InitCandidateWindowView() {
+  if (candidate_window_view_)
+    return;
+
+  candidate_window_view_ = new CandidateWindowView(ash::Shell::GetContainer(
+      ash::Shell::GetTargetRootWindow(),
+      ash::internal::kShellWindowId_InputMethodContainer));
+  candidate_window_view_->AddObserver(this);
+  candidate_window_view_->SetCursorBounds(cursor_bounds_, composition_head_);
+  views::Widget* widget = candidate_window_view_->InitWidget();
+  widget->AddObserver(this);
+  widget->Show();
+  FOR_EACH_OBSERVER(CandidateWindowController::Observer, observers_,
+                    CandidateWindowOpened());
+}
+
 void CandidateWindowControllerImpl::Hide() {
-  // To hide the candidate window we have to call HideLookupTable and
-  // HideAuxiliaryText. Without calling HideAuxiliaryText the
-  // auxiliary text area will remain.
-  candidate_window_view_->HideLookupTable();
-  candidate_window_view_->HideAuxiliaryText();
+  if (candidate_window_view_)
+    candidate_window_view_->GetWidget()->Close();
   if (infolist_window_)
     infolist_window_->HideImmediately();
 }
 
 void CandidateWindowControllerImpl::SetCursorBounds(
     const gfx::Rect& cursor_bounds,
     const gfx::Rect& composition_head) {
   // A workaround for http://crosbug.com/6460. We should ignore very short Y
   // move to prevent the window from shaking up and down.
   const int kKeepPositionThreshold = 2;  // px
-  const gfx::Rect& last_bounds =
-      candidate_window_view_->cursor_bounds();
+  gfx::Rect last_bounds;
+  if (candidate_window_view_)
+    last_bounds = candidate_window_view_->GetAnchorRect();
+
   const int delta_y = abs(last_bounds.y() - cursor_bounds.y());
   if ((last_bounds.x() == cursor_bounds.x()) &&
       (delta_y <= kKeepPositionThreshold)) {
     DVLOG(1) << "Ignored set_cursor_bounds signal to prevent window shake";
     return;
   }
 
+  cursor_bounds_ = cursor_bounds;
+  composition_head_ = composition_head;
+
   // Remember the cursor bounds.
-  candidate_window_view_->set_cursor_bounds(cursor_bounds);
-  candidate_window_view_->set_composition_head_bounds(composition_head);
-  // Move the window per the cursor bounds.
-  candidate_window_view_->ResizeAndMoveParentFrame();
+  if (candidate_window_view_)
+    candidate_window_view_->SetCursorBounds(cursor_bounds, composition_head);
   if (infolist_window_)
     infolist_window_->GetWidget()->SetBounds(GetInfolistBounds());
 
   // Mode indicator controller also needs the cursor bounds.
   mode_indicator_controller_->SetCursorBounds(cursor_bounds);
 }
 
 void CandidateWindowControllerImpl::UpdateAuxiliaryText(
     const std::string& utf8_text,
     bool visible) {
   // If it's not visible, hide the auxiliary text and return.
   if (!visible) {
-    candidate_window_view_->HideAuxiliaryText();
+    if (candidate_window_view_)
+      candidate_window_view_->HideAuxiliaryText();
     return;
   }
+
+  if (!candidate_window_view_)
+    InitCandidateWindowView();
+
   candidate_window_view_->UpdateAuxiliaryText(utf8_text);
   candidate_window_view_->ShowAuxiliaryText();
 }
 
 void CandidateWindowControllerImpl::FocusStateChanged(bool is_focused) {
   mode_indicator_controller_->FocusStateChanged(is_focused);
 }
 
 // static
 void CandidateWindowControllerImpl::ConvertLookupTableToInfolistEntry(
@@ skipping 22 matching lines @@
     }
     infolist_entries->push_back(entry);
   }
 }
 
 void CandidateWindowControllerImpl::UpdateLookupTable(
     const CandidateWindow& candidate_window,
     bool visible) {
   // If it's not visible, hide the lookup table and return.
   if (!visible) {
-    candidate_window_view_->HideLookupTable();
+    if (candidate_window_view_)
+      candidate_window_view_->HideLookupTable();
     if (infolist_window_)
       infolist_window_->HideImmediately();
     // TODO(nona): Introduce unittests for crbug.com/170036.
     latest_infolist_entries_.clear();
     return;
   }
 
+  if (!candidate_window_view_)
+    InitCandidateWindowView();
   candidate_window_view_->UpdateCandidates(candidate_window);
   candidate_window_view_->ShowLookupTable();
 
   bool has_highlighted = false;
   std::vector<InfolistEntry> infolist_entries;
   ConvertLookupTableToInfolistEntry(candidate_window, &infolist_entries,
                                     &has_highlighted);
 
   // If there is no change, just return.
   if (latest_infolist_entries_ == infolist_entries)
@@ skipping 25 matching lines @@
             ash::internal::kShellWindowId_InputMethodContainer),
         GetInfolistBounds());
     infolist_window_->GetWidget()->AddObserver(this);
   }
   infolist_window_->ShowWithDelay();
 }
 
 gfx::Rect CandidateWindowControllerImpl::GetInfolistBounds() {
   gfx::Rect new_bounds(infolist_window_->GetPreferredSize());
   // Infolist has to be in the same display of the candidate window.
-  gfx::NativeWindow native_frame = frame_->GetNativeWindow();
+  gfx::NativeWindow native_frame =
+      candidate_window_view_->GetWidget()->GetNativeWindow();
   new_bounds.set_origin(GetInfolistWindowPosition(
-        frame_->GetClientAreaBoundsInScreen(),
-        gfx::Screen::GetScreenFor(native_frame)->GetDisplayNearestWindow(
-            native_frame).work_area(),
-        new_bounds.size()));
+      candidate_window_view_->GetWidget()->GetClientAreaBoundsInScreen(),
+      gfx::Screen::GetScreenFor(native_frame)->GetDisplayNearestWindow(
+          native_frame).work_area(),
+      new_bounds.size()));
   return new_bounds;
 }
 
 void CandidateWindowControllerImpl::UpdatePreeditText(
     const std::string& utf8_text, unsigned int cursor, bool visible) {
   // If it's not visible, hide the preedit text and return.
   if (!visible || utf8_text.empty()) {
-    candidate_window_view_->HidePreeditText();
+    if (candidate_window_view_)
+      candidate_window_view_->HidePreeditText();
     return;
   }
+  if (!candidate_window_view_)
+    InitCandidateWindowView();

[Hiro Komatsu, 2013/12/27 07:13:34]

When the only composition text  is updated, the candidate window should not be
shown.

How about separating preedit_view from candidate_window_view?  In this case, I
prefer "composition" instead of "preedit".

[Jun Mukai, 2013/12/27 11:01:13]

This is only for the preedit in the candidate window.

   candidate_window_view_->UpdatePreeditText(utf8_text);
   candidate_window_view_->ShowPreeditText();
 }
 
 void CandidateWindowControllerImpl::OnCandidateCommitted(int index) {
   FOR_EACH_OBSERVER(CandidateWindowController::Observer, observers_,
                     CandidateClicked(index));
 }
 
-void CandidateWindowControllerImpl::OnCandidateWindowOpened() {
-  FOR_EACH_OBSERVER(CandidateWindowController::Observer, observers_,
-                    CandidateWindowOpened());
-}
-
-void CandidateWindowControllerImpl::OnCandidateWindowClosed() {
-  FOR_EACH_OBSERVER(CandidateWindowController::Observer, observers_,
-                    CandidateWindowClosed());
-}
-
 void CandidateWindowControllerImpl::OnWidgetClosing(views::Widget* widget) {
   if (infolist_window_ && widget == infolist_window_->GetWidget()) {
     widget->RemoveObserver(this);
     infolist_window_ = NULL;
+  } else if (candidate_window_view_ &&
+             widget == candidate_window_view_->GetWidget()) {
+    widget->RemoveObserver(this);
+    candidate_window_view_->RemoveObserver(this);
+    candidate_window_view_ = NULL;
+    FOR_EACH_OBSERVER(CandidateWindowController::Observer, observers_,
+                      CandidateWindowClosed());
   }
 }
 
 void CandidateWindowControllerImpl::AddObserver(
     CandidateWindowController::Observer* observer) {
   observers_.AddObserver(observer);
 }
 
 void CandidateWindowControllerImpl::RemoveObserver(
     CandidateWindowController::Observer* observer) {
@@ skipping 14 matching lines @@
 
   if (candidate_window_view_rect.y() + infolist_window_size.height() >
       screen_rect.bottom())
     result.set_y(screen_rect.bottom() - infolist_window_size.height());
 
   return result;
 }
 
 }  // namespace input_method
 }  // namespace chromeos