Issue 1210033007: Cache some global constants in Thread, to allow access via THR register.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1210033007: Cache some global constants in Thread, to allow access via THR register. (Closed)

Created:
5 years, 5 months ago by koda

Modified:
5 years, 5 months ago

Reviewers:
Florian Schneider

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Cache some global constants in Thread, to allow access via THR register. In particular, do this for null, true, false, and the entry point of the UpdateStoreBufferStub. This will help supporting precompilation and reduce memory usage from constant pools (assuming there are more constant pools than threads). BUG= This was landed as part of https://github.com/dart-lang/sdk/commit/3b8cbf8bfa53797e100e96f70ea57677f3006b46.

Patch Set 1 #

Patch Set 2 : Remove unused define. #

Created: 5 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+84 lines, -9 lines)			Patch
M	runtime/vm/assembler_ia32.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/assembler_ia32.cc	View		1 chunk	+10 lines, -0 lines	0 comments	Download
M	runtime/vm/dart.cc	View		3 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/stub_code.h	View		2 chunks	+1 line, -1 line	0 comments	Download
M	runtime/vm/stub_code_ia32.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/thread.h	View		3 chunks	+28 lines, -3 lines	0 comments	Download
M	runtime/vm/thread.cc	View	1	3 chunks	+39 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

koda

Note: this is a proof of concept, not intended for submission as-is. A complete CL ...

5 years, 5 months ago (2015-07-06 23:09:47 UTC) #2

Florian Schneider

5 years, 5 months ago (2015-07-07 08:00:15 UTC) #3

Approach looks good! On ia32 I think we still use the old way of loading
constants since there is no object pool there.

Do you want to proceed with it, or should I go ahead with the other platforms
(x64, arm64, arm, mips)?

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages