runtime/vm/stub_code_ia32.cc - Issue 1210033007: Cache some global constants in Thread, to allow access via THR register.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/stub_code_ia32.cc

Issue 1210033007: Cache some global constants in Thread, to allow access via THR register. (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: Remove unused define. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/vm/stub_code_ia32.cc

diff --git a/runtime/vm/stub_code_ia32.cc b/runtime/vm/stub_code_ia32.cc

index 95ba1116eda3a0bf588835728e69124790a01aca..1fe54cbcf701ecb83398e7806e245a1fa8fac0ad 100644

--- a/runtime/vm/stub_code_ia32.cc

+++ b/runtime/vm/stub_code_ia32.cc

@@ -1269,10 +1269,10 @@ static void EmitFastSmiOp(Assembler* assembler,

Label done, is_true;

__ cmpl(EAX, EDI);

__ j(EQUAL, &is_true, Assembler::kNearJump);

- __ LoadObject(EAX, Bool::False());

+ __ LoadBoolFalse(EAX);

__ jmp(&done, Assembler::kNearJump);

__ Bind(&is_true);

- __ LoadObject(EAX, Bool::True());

+ __ LoadBoolTrue(EAX);

__ Bind(&done);

break;

}

« no previous file with comments | « runtime/vm/stub_code.h ('k') | runtime/vm/thread.h » ('j') | no next file with comments »