clang/win: Fix warnings to prepare for building without -Wno-reorder.

clang/win: Fix warnings to prepare for building without -Wno-reorder.

This changes constructor initializer list ordering to match field
declaration ordering, except for gtest and breakpad, where the warning
is disabled.

BUG=505304
NOPRESUBMIT=true

Committed: https://crrev.com/5648c8598f20bc9756a82cf90cee204db44ea269
Cr-Commit-Position: refs/heads/master@{#337152}

[Sam McNally, 2015-06-30 08:11:27]

sammc@chromium.org changed reviewers:
+ brettw@chromium.org, rpaquay@chromium.org, thakis@chromium.org

[Sam McNally, 2015-06-30 08:11:28]

rpaquay@chromium.org: Please review changes in device/bluetooth.

thakis@chromium.org: Please review changes in base, build, chrome, ui,
testing/gtest.gyp.

brettw@chromium.org: Please review changes everywhere else.

[rpaquay, 2015-06-30 16:37:40]

device/bluetooth lgtm

[Nico, 2015-06-30 18:03:50]

lgtm, super cool!

brettw, I looked through all your files too, so if you want you can just stamp
this.

https://codereview.chromium.org/1210013007/diff/1/build/secondary/testing/gte...
File build/secondary/testing/gtest/BUILD.gn (right):

https://codereview.chromium.org/1210013007/diff/1/build/secondary/testing/gte...
build/secondary/testing/gtest/BUILD.gn:27: # ordered.
Can you file an upstream bug for this?

https://codereview.chromium.org/1210013007/diff/1/testing/gtest.gyp
File testing/gtest.gyp (right):

https://codereview.chromium.org/1210013007/diff/1/testing/gtest.gyp#newcode197
testing/gtest.gyp:197: # incorrectly ordered.
Can you file an upstream bug for this and link to it in this comment?

[brettw, 2015-06-30 21:17:04]

LGTM based on Nico's comment (I didn't look).

[Sam McNally, 2015-07-02 00:12:13]

My nacl cl (https://codereview.chromium.org/1221833003/) seems unlikely to land
today so I'm going to remove enabling the warning from this cl.

I also had to add a disable for breakpad. PTAL.

https://codereview.chromium.org/1210013007/diff/1/build/secondary/testing/gte...
File build/secondary/testing/gtest/BUILD.gn (right):

https://codereview.chromium.org/1210013007/diff/1/build/secondary/testing/gte...
build/secondary/testing/gtest/BUILD.gn:27: # ordered.
On 2015/06/30 18:03:50, Nico wrote:
> Can you file an upstream bug for this?

Done.

https://codereview.chromium.org/1210013007/diff/1/testing/gtest.gyp
File testing/gtest.gyp (right):

https://codereview.chromium.org/1210013007/diff/1/testing/gtest.gyp#newcode197
testing/gtest.gyp:197: # incorrectly ordered.
On 2015/06/30 18:03:50, Nico wrote:
> Can you file an upstream bug for this and link to it in this comment?

Done.

[Nico, 2015-07-02 00:15:52]

lgtm

[Sam McNally, 2015-07-02 00:16:55]

The CQ bit was checked by sammc@chromium.org

[Sam McNally, 2015-07-02 00:16:56]

The patchset sent to the CQ was uploaded after l-g-t-m from
rpaquay@chromium.org, brettw@chromium.org
Link to the patchset: https://codereview.chromium.org/1210013007/#ps20001
(title: " ")

[commit-bot: I haz the power, 2015-07-02 00:18:05]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210013007/20001

[commit-bot: I haz the power, 2015-07-02 00:28:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-07-02 00:28:37]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[Sam McNally, 2015-07-02 00:30:29]

The CQ bit was checked by sammc@chromium.org

[commit-bot: I haz the power, 2015-07-02 00:31:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1210013007/20001

[commit-bot: I haz the power, 2015-07-02 01:25:12]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-07-02 01:26:06]

Patchset 2 (id:??) landed as
https://crrev.com/5648c8598f20bc9756a82cf90cee204db44ea269
Cr-Commit-Position: refs/heads/master@{#337152}