win8/metro_driver/file_picker_ash.cc - Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: win8/metro_driver/file_picker_ash.cc

Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-unsequenced

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: win8/metro_driver/file_picker_ash.cc

diff --git a/win8/metro_driver/file_picker_ash.cc b/win8/metro_driver/file_picker_ash.cc

index d88d28678849edd71e6707dc43d653cac95a8e05..e45301c7f8eff1c4677389f544ed78393ef51983 100644

--- a/win8/metro_driver/file_picker_ash.cc

+++ b/win8/metro_driver/file_picker_ash.cc

@@ -84,11 +84,11 @@ FilePickerSessionBase::FilePickerSessionBase(ChromeAppViewAsh* app_view,

const base::string16& title,

const base::string16& filter,

const base::FilePath& default_path)

- : app_view_(app_view),

+ : success_(false),

title_(title),

filter_(filter),

default_path_(default_path),

- success_(false) {

+ app_view_(app_view) {

}

bool FilePickerSessionBase::DoFilePicker() {

« no previous file with comments | « win8/metro_driver/chrome_app_view_ash.cc ('k') | win8/metro_driver/ime/text_store.cc » ('j') | no next file with comments »