testing/gtest.gyp - Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: testing/gtest.gyp

Issue 1210013007: clang/win: Fix warnings to prepare for building without -Wno-reorder. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@clang-unsequenced

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: testing/gtest.gyp

diff --git a/testing/gtest.gyp b/testing/gtest.gyp

index d61772ecbe23323760e2a22a8364697bf88cbe29..79d7e669800e3a1614df0027537bc52c951a9b0d 100644

--- a/testing/gtest.gyp

+++ b/testing/gtest.gyp

@@ -191,6 +191,14 @@

'msvs_disabled_warnings': [4800],

+ 'variables': {

+ 'clang_warning_flags': [

+ # The Mutex constructor initializer list in gtest-port.cc is

+ # incorrectly ordered. See

+ # https://groups.google.com/d/msg/googletestframework/S5uSV8L2TX8/U1FaTDa6J6sJ.

+ '-Wno-reorder',

+ ]

+ },

{

'target_name': 'gtest_main',

« no previous file with comments | « sandbox/win/src/service_resolver.h ('k') | third_party/leveldatabase/env_chromium.cc » ('j') | no next file with comments »