Source/modules/credentialmanager/PasswordCredential.h - Issue 1209953002: Rename avatarURL to iconURL in the credential manager in Blink.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/modules/credentialmanager/PasswordCredential.h

Issue 1209953002: Rename avatarURL to iconURL in the credential manager in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/modules/credentialmanager/FederatedCredential.h ('k') | Source/modules/credentialmanager/PasswordCredential.cpp » ('j') | public/platform/WebCredential.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/modules/credentialmanager/PasswordCredential.h

diff --git a/Source/modules/credentialmanager/PasswordCredential.h b/Source/modules/credentialmanager/PasswordCredential.h

index a7e8b478a4607a5ff797e73f02a69702550365f3..304fb841f5b795c0cf9c561c59a224a7ac480fa4 100644

--- a/Source/modules/credentialmanager/PasswordCredential.h

+++ b/Source/modules/credentialmanager/PasswordCredential.h

@@ -29,7 +29,7 @@ public:

return create(id, password, name, emptyString(), exceptionState);

}

- static PasswordCredential* create(const String& id, const String& password, const String& name, const String& avatar, ExceptionState&);

+ static PasswordCredential* create(const String& id, const String& password, const String& name, const String& icon, ExceptionState&);

static PasswordCredential* create(WebPasswordCredential*);

// PasswordCredential.idl

@@ -40,7 +40,7 @@ public:

private:

PasswordCredential(WebPasswordCredential*);

- PasswordCredential(const String& id, const String& password, const String& name, const KURL& avatar);

+ PasswordCredential(const String& id, const String& password, const String& name, const KURL& icon);

Member<DOMFormData> m_formData;

};