Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(767)

Unified Diff: public/platform/WebCredential.h

Issue 1209953002: Rename avatarURL to iconURL in the credential manager in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/platform/exported/WebPasswordCredential.cpp ('k') | public/platform/WebFederatedCredential.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: public/platform/WebCredential.h
diff --git a/public/platform/WebCredential.h b/public/platform/WebCredential.h
index f40a3c159226da1d00bcfa0e8d69420d2f6b4884..0423681dcadb2f0e635679b601e1b4a4de46d101 100644
--- a/public/platform/WebCredential.h
+++ b/public/platform/WebCredential.h
@@ -16,7 +16,7 @@ class PlatformCredential;
class WebCredential {
public:
- BLINK_PLATFORM_EXPORT WebCredential(const WebString& id, const WebString& name, const WebURL& avatarURL);
+ BLINK_PLATFORM_EXPORT WebCredential(const WebString& id, const WebString& name, const WebURL& iconURL);
BLINK_PLATFORM_EXPORT WebCredential(const WebCredential&);
virtual ~WebCredential() { reset(); }
@@ -25,14 +25,15 @@ public:
BLINK_PLATFORM_EXPORT WebString id() const;
BLINK_PLATFORM_EXPORT WebString name() const;
- BLINK_PLATFORM_EXPORT WebURL avatarURL() const;
+ BLINK_PLATFORM_EXPORT WebURL iconURL() const;
BLINK_PLATFORM_EXPORT WebString type() const;
BLINK_PLATFORM_EXPORT bool isPasswordCredential() const;
BLINK_PLATFORM_EXPORT bool isFederatedCredential() const;
- // TODO(mkwst): Drop this once Chromium is updated. https://crbug.com/494880
+ // TODO(mkwst, msramek): Drop this once Chromium is updated. https://crbug.com/494880
Mike West 2015/06/25 14:48:42 I think you can just leave this with my name in it
msramek 2015/06/26 09:45:04 Well, let me just remove it in the third correspon
BLINK_PLATFORM_EXPORT bool isLocalCredential() const { return isPasswordCredential(); }
+ BLINK_PLATFORM_EXPORT WebURL avatarURL() const { return iconURL(); }
#if INSIDE_BLINK
BLINK_PLATFORM_EXPORT static WebCredential create(PlatformCredential*);
« no previous file with comments | « Source/platform/exported/WebPasswordCredential.cpp ('k') | public/platform/WebFederatedCredential.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698