Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2086)

Unified Diff: Source/modules/credentialmanager/PasswordCredential.cpp

Issue 1209953002: Rename avatarURL to iconURL in the credential manager in Blink. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/credentialmanager/PasswordCredential.cpp
diff --git a/Source/modules/credentialmanager/PasswordCredential.cpp b/Source/modules/credentialmanager/PasswordCredential.cpp
index 6df7e7c542c3e1420178f626c4aed77c9aef75b8..002d973529b62b1d1cb3247b245837439dadc53b 100644
--- a/Source/modules/credentialmanager/PasswordCredential.cpp
+++ b/Source/modules/credentialmanager/PasswordCredential.cpp
@@ -18,12 +18,12 @@ PasswordCredential* PasswordCredential::create(WebPasswordCredential* webPasswor
return new PasswordCredential(webPasswordCredential);
}
-PasswordCredential* PasswordCredential::create(const String& id, const String& password, const String& name, const String& avatar, ExceptionState& exceptionState)
+PasswordCredential* PasswordCredential::create(const String& id, const String& password, const String& name, const String& icon, ExceptionState& exceptionState)
{
- KURL avatarURL = parseStringAsURL(avatar, exceptionState);
+ KURL iconURL = parseStringAsURL(icon, exceptionState);
if (exceptionState.hadException())
return nullptr;
- return new PasswordCredential(id, password, name, avatarURL);
+ return new PasswordCredential(id, password, name, iconURL);
}
PasswordCredential::PasswordCredential(WebPasswordCredential* webPasswordCredential)
@@ -31,8 +31,8 @@ PasswordCredential::PasswordCredential(WebPasswordCredential* webPasswordCredent
{
}
-PasswordCredential::PasswordCredential(const String& id, const String& password, const String& name, const KURL& avatar)
- : Credential(PlatformPasswordCredential::create(id, password, name, avatar))
+PasswordCredential::PasswordCredential(const String& id, const String& password, const String& name, const KURL& icon)
+ : Credential(PlatformPasswordCredential::create(id, password, name, icon))
, m_formData(DOMFormData::create())
{
m_formData->append("username", id);

Powered by Google App Engine
This is Rietveld 408576698