Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: test/ninja/duplicate-ldflags/gyptest-duplicate-ldflags.py

Issue 1209553002: Do not remote duplicate entries from ldflags when generating ninja files as it changes behavior (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Added test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/ninja/duplicate-ldflags/test.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/ninja/duplicate-ldflags/gyptest-duplicate-ldflags.py
diff --git a/test/ninja/duplicate-ldflags/gyptest-duplicate-ldflags.py b/test/ninja/duplicate-ldflags/gyptest-duplicate-ldflags.py
new file mode 100644
index 0000000000000000000000000000000000000000..41b7fffccf71a21842ac4edf37c1229b09cfeda6
--- /dev/null
+++ b/test/ninja/duplicate-ldflags/gyptest-duplicate-ldflags.py
@@ -0,0 +1,21 @@
+#!/usr/bin/env python
+
+# Copyright (c) 2015 Google Inc. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+"""
+Verifies duplicate ldflags are not removed.
+"""
+
+import TestGyp
+
+test = TestGyp.TestGyp(formats=['ninja'])
+test.run_gyp('test.gyp')
+
+test.must_contain('out/Default/obj/All.ninja',
+ '-Wl,--whole-archive lib1.a -Wl,--no-whole-archive')
Nico 2015/06/25 16:02:21 Can you rewrite this to not inspect the ninja file
+test.must_contain('out/Default/obj/All.ninja',
+ '-Wl,--whole-archive lib2.a -Wl,--no-whole-archive')
+
+test.pass_test()
« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/ninja/duplicate-ldflags/test.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698