test/ninja/duplicate-ldflags/gyptest-duplicate-ldflags.py - Issue 1209553002: Do not remote duplicate entries from ldflags when generating ninja files as it changes behavior

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: test/ninja/duplicate-ldflags/gyptest-duplicate-ldflags.py

Issue 1209553002: Do not remote duplicate entries from ldflags when generating ninja files as it changes behavior (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: Added test Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 #!/usr/bin/env python

	2

	3 # Copyright (c) 2015 Google Inc. All rights reserved.

	4 # Use of this source code is governed by a BSD-style license that can be

	5 # found in the LICENSE file.

	6

	7 """

	8 Verifies duplicate ldflags are not removed.

	9 """

	10

	11 import TestGyp

	12

	13 test = TestGyp.TestGyp(formats=['ninja'])

	14 test.run_gyp('test.gyp')

	15

	16 test.must_contain('out/Default/obj/All.ninja',

	17 '-Wl,--whole-archive lib1.a -Wl,--no-whole-archive')
	Nico 2015/06/25 16:02:21 Can you rewrite this to not inspect the ninja file Can you rewrite this to not inspect the ninja files? I think if you use a make_global_settings block with a LINK_wrapper pointing at some python script, the script can inspect the link flags. Then the test would work with make and ninja and would also test that the two generators are consistent.
	18 test.must_contain('out/Default/obj/All.ninja',

	19 '-Wl,--whole-archive lib2.a -Wl,--no-whole-archive')

	20

	21 test.pass_test()

OLD	NEW

« no previous file with comments | « pylib/gyp/generator/ninja.py ('k') | test/ninja/duplicate-ldflags/test.gyp » ('j') | no next file with comments »