Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(916)

Unified Diff: test/ninja/duplicate-ldflags/test.gyp

Issue 1209553002: Do not remote duplicate entries from ldflags when generating ninja files as it changes behavior (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: Added test Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/ninja/duplicate-ldflags/test.gyp
diff --git a/test/analyzer/test5.gyp b/test/ninja/duplicate-ldflags/test.gyp
similarity index 55%
copy from test/analyzer/test5.gyp
copy to test/ninja/duplicate-ldflags/test.gyp
index f3ea5b00612d086d83f6607cfb357749b3c586dd..43ad739e77d74addb5a90861ed2838e62c5f75b7 100644
--- a/test/analyzer/test5.gyp
+++ b/test/ninja/duplicate-ldflags/test.gyp
@@ -5,20 +5,17 @@
{
'targets': [
{
- 'target_name': 'f',
+ 'target_name': 'All',
'type': 'executable',
- 'sources': [
- 'f.c',
+ 'ldflags': [
+ '-Wl,--whole-archive lib1.a',
+ '-Wl,--no-whole-archive',
+
+ '-Wl,--whole-archive lib2.a',
+ '-Wl,--no-whole-archive',
],
- },
- {
- 'target_name': 'g',
- 'type': 'executable',
'sources': [
- 'g.c',
- ],
- 'dependencies': [
- 'f',
+ 'main.cc',
],
},
],

Powered by Google App Engine
This is Rietveld 408576698