Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(324)

Issue 1209423005: Sync the Presentation API interfaces with the spec (Closed)

Created:
5 years, 5 months ago by philipj_slow
Modified:
5 years, 5 months ago
Reviewers:
whywhat
CC:
blink-reviews, mlamouri (slow - plz ping)
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 7

Patch Set 2 : Assign TODOs to Anton #

Patch Set 3 : add issue link #

Patch Set 4 : Drop speculative TODO #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -17 lines) Patch
M Source/modules/presentation/DefaultSessionStartEvent.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/presentation/DefaultSessionStartEventInit.idl View 1 chunk +3 lines, -1 line 0 comments Download
M Source/modules/presentation/NavigatorPresentation.idl View 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/presentation/Presentation.idl View 1 2 3 1 chunk +12 lines, -6 lines 0 comments Download
M Source/modules/presentation/PresentationAvailability.idl View 2 chunks +1 line, -2 lines 0 comments Download
M Source/modules/presentation/PresentationSession.idl View 1 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209423005/1
5 years, 5 months ago (2015-07-07 12:47:13 UTC) #2
philipj_slow
PTAL. If you want them, I'll happily reassign the TODOs to you :)
5 years, 5 months ago (2015-07-07 12:47:39 UTC) #4
whywhat
Thanks Philip! I left a couple of comments about two TODOs. You can assign the ...
5 years, 5 months ago (2015-07-07 13:00:07 UTC) #5
whywhat
lgtm
5 years, 5 months ago (2015-07-07 13:00:14 UTC) #6
philipj_slow
https://codereview.chromium.org/1209423005/diff/1/Source/modules/presentation/Presentation.idl File Source/modules/presentation/Presentation.idl (right): https://codereview.chromium.org/1209423005/diff/1/Source/modules/presentation/Presentation.idl#newcode14 Source/modules/presentation/Presentation.idl:14: // TODO(philipj): The |presentationId| argument is not in the ...
5 years, 5 months ago (2015-07-07 13:18:32 UTC) #7
philipj_slow
Assign TODOs to Anton
5 years, 5 months ago (2015-07-07 13:23:54 UTC) #8
whywhat
Commented on the GitHub issue. https://codereview.chromium.org/1209423005/diff/1/Source/modules/presentation/Presentation.idl File Source/modules/presentation/Presentation.idl (right): https://codereview.chromium.org/1209423005/diff/1/Source/modules/presentation/Presentation.idl#newcode14 Source/modules/presentation/Presentation.idl:14: // TODO(philipj): The |presentationId| ...
5 years, 5 months ago (2015-07-07 13:53:58 UTC) #9
philipj_slow
https://codereview.chromium.org/1209423005/diff/1/Source/modules/presentation/Presentation.idl File Source/modules/presentation/Presentation.idl (right): https://codereview.chromium.org/1209423005/diff/1/Source/modules/presentation/Presentation.idl#newcode14 Source/modules/presentation/Presentation.idl:14: // TODO(philipj): The |presentationId| argument is not in the ...
5 years, 5 months ago (2015-07-07 14:31:02 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209423005/60001
5 years, 5 months ago (2015-07-07 14:33:05 UTC) #13
commit-bot: I haz the power
5 years, 5 months ago (2015-07-07 15:34:34 UTC) #14
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=198408

Powered by Google App Engine
This is Rietveld 408576698