Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1832)

Unified Diff: Source/modules/presentation/Presentation.idl

Issue 1209423005: Sync the Presentation API interfaces with the spec (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Drop speculative TODO Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/modules/presentation/Presentation.idl
diff --git a/Source/modules/presentation/Presentation.idl b/Source/modules/presentation/Presentation.idl
index 0c104b5a76e1b343fea06b526446256c988920b0..8e459bd1c39f871e20d9503ff084377ac086f140 100644
--- a/Source/modules/presentation/Presentation.idl
+++ b/Source/modules/presentation/Presentation.idl
@@ -4,16 +4,22 @@
// https://w3c.github.io/presentation-api/#navigatorpresentation
+// TODO(avayvod): This interface is named NavigatorPresentation in the spec:
+// https://github.com/w3c/presentation-api/issues/137
[
GarbageCollected,
RuntimeEnabled=Presentation
] interface Presentation : EventTarget {
- readonly attribute PresentationSession? session;
-
- [CallWith=ScriptState] Promise<PresentationSession> startSession(DOMString presentationUrl, [Default=Undefined] optional DOMString presentationId);
- [CallWith=ScriptState] Promise<PresentationSession> joinSession(DOMString presentationUrl, [Default=Undefined] optional DOMString presentationId);
-
+ // This API used by controlling browsing context.
+ // TODO(avayvod): The |presentationId| argument is not in the spec.
+ [CallWith=ScriptState] Promise<PresentationSession> startSession(DOMString url, [Default=Undefined] optional DOMString presentationId);
+ // TODO(avayvod): The |presentationId| argument should not be optional.
+ [CallWith=ScriptState] Promise<PresentationSession> joinSession(DOMString url, [Default=Undefined] optional DOMString presentationId);
+ [CallWith=ScriptState] Promise<PresentationAvailability> getAvailability(DOMString url);
attribute EventHandler ondefaultsessionstart;
- [CallWith=ScriptState] Promise<PresentationAvailability> getAvailability(DOMString presentationUrl);
+ // This API used by presenting browsing context.
+ // TODO(avayvod): The spec has |getSession()| and |getSessions()| instead.
+ readonly attribute PresentationSession? session;
+ // TODO(avayvod): attribute EventHandler onsessionavailable;
};
« no previous file with comments | « Source/modules/presentation/NavigatorPresentation.idl ('k') | Source/modules/presentation/PresentationAvailability.idl » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698