icu.gyp - Issue 1209413007: Suppress warnings for assignment inside conditionals.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: icu.gyp

Issue 1209413007: Suppress warnings for assignment inside conditionals. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master

Patch Set: Address more feedback Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: icu.gyp

diff --git a/icu.gyp b/icu.gyp

index 8b336e96659fb88108cf9eb1200f102d78f9db0f..823f2b9575dc4b49c8e97636c1157fa192cc873a 100644

--- a/icu.gyp

+++ b/icu.gyp

@@ -198,6 +198,9 @@

'-Wno-logical-op-parentheses',

# ICU has some `unsigned < 0` checks.

'-Wno-tautological-compare',

+ # ICU has some code with the pattern:

+ # if (found = uprv_getWindowsTimeZoneInfo(...))

+ '-Wno-parentheses',

# Since ICU wants to internally use its own deprecated APIs, don't

@@ -287,6 +290,9 @@

# enum (e.g. URES_TABLE32 which is in UResInternalType). This

# is on purpose.

'-Wno-switch',

+ # ICU has some code with the pattern:

+ # if (found = uprv_getWindowsTimeZoneInfo(...))

+ '-Wno-parentheses',

'cflags': [

« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »