Suppress warnings for assignment inside conditionals.

BUILD.gn

Index: BUILD.gn
diff --git a/BUILD.gn b/BUILD.gn
index 24fe92716c7dec50e0431a769956848c20e12c5d..1f52723f1c7be9c7b05b01e32d2739ad7e2fe685 100644
--- a/BUILD.gn
+++ b/BUILD.gn
@@ -71,7 +71,8 @@ config("icu_code") {
       "-Wno-logical-op-parentheses",
       "-Wno-tautological-compare",
       "-Wno-switch",
-    ]
+      "-Wno-parentheses",
+      ]
     if (is_win) {
       cflags += [
         # See http://bugs.icu-project.org/trac/ticket/11122
@@ -481,7 +482,6 @@ component("icuuc") {
   deps = [
     ":icudata",
   ]
-  configs += [ ":icu_code" ]
 
   configs -= [
     "//build/config/compiler:no_rtti",  # ICU uses RTTI.
@@ -492,6 +492,7 @@ component("icuuc") {
     "//build/config/compiler:no_chromium_code",
   ]
 
+  configs += [ ":icu_code" ]

[dcheng, 2015/06/30 21:18:09]

Apparently it wasn't really suppressing the warnings before. It is now =)

[Nico, 2015/06/30 21:32:58]

Ah cool. Yes, the += appends no_chromium_code to configs which adds -Wall, so
the compile command would end up with

  "-Wno-foo -Wall"

and Wfoo was part of Wall so Wall reenabled it. Now the -Wno-foo is passed after
-Wall.

This transformation isn't safe in general: If icu_code added include
directories, you'd want the icu_code directories to come in front of the general
include directories. Since it only contains defines and warning flags, this is a
good change however.

   public_configs = [ ":icu_config" ]
 
   if (is_win || icu_use_data_file) {