Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Side by Side Diff: icu.gyp

Issue 1209413007: Suppress warnings for assignment inside conditionals. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Address more feedback Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 { 5 {
6 'includes': [ 6 'includes': [
7 'icu.gypi', 7 'icu.gypi',
8 ], 8 ],
9 'variables': { 9 'variables': {
10 'use_system_icu%': 0, 10 'use_system_icu%': 0,
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
191 ], 191 ],
192 }, 192 },
193 'variables': { 193 'variables': {
194 'clang_warning_flags': [ 194 'clang_warning_flags': [
195 # ICU uses its own deprecated functions. 195 # ICU uses its own deprecated functions.
196 '-Wno-deprecated-declarations', 196 '-Wno-deprecated-declarations',
197 # ICU prefers `a && b || c` over `(a && b) || c`. 197 # ICU prefers `a && b || c` over `(a && b) || c`.
198 '-Wno-logical-op-parentheses', 198 '-Wno-logical-op-parentheses',
199 # ICU has some `unsigned < 0` checks. 199 # ICU has some `unsigned < 0` checks.
200 '-Wno-tautological-compare', 200 '-Wno-tautological-compare',
201 # ICU has some code with the pattern:
202 # if (found = uprv_getWindowsTimeZoneInfo(...))
203 '-Wno-parentheses',
201 ], 204 ],
202 }, 205 },
203 # Since ICU wants to internally use its own deprecated APIs, don't 206 # Since ICU wants to internally use its own deprecated APIs, don't
204 # complain about it. 207 # complain about it.
205 'cflags': [ 208 'cflags': [
206 '-Wno-deprecated-declarations', 209 '-Wno-deprecated-declarations',
207 ], 210 ],
208 'cflags_cc': [ 211 'cflags_cc': [
209 '-frtti', 212 '-frtti',
210 ], 213 ],
(...skipping 69 matching lines...) Expand 10 before | Expand all | Expand 10 after
280 # ICU prefers `a && b || c` over `(a && b) || c`. 283 # ICU prefers `a && b || c` over `(a && b) || c`.
281 '-Wno-logical-op-parentheses', 284 '-Wno-logical-op-parentheses',
282 # ICU has some `unsigned < 0` checks. 285 # ICU has some `unsigned < 0` checks.
283 '-Wno-tautological-compare', 286 '-Wno-tautological-compare',
284 # uresdata.c has switch(RES_GET_TYPE(x)) code. The 287 # uresdata.c has switch(RES_GET_TYPE(x)) code. The
285 # RES_GET_TYPE macro returns an UResType enum, but some switch 288 # RES_GET_TYPE macro returns an UResType enum, but some switch
286 # statement contains case values that aren't part of that 289 # statement contains case values that aren't part of that
287 # enum (e.g. URES_TABLE32 which is in UResInternalType). This 290 # enum (e.g. URES_TABLE32 which is in UResInternalType). This
288 # is on purpose. 291 # is on purpose.
289 '-Wno-switch', 292 '-Wno-switch',
293 # ICU has some code with the pattern:
294 # if (found = uprv_getWindowsTimeZoneInfo(...))
295 '-Wno-parentheses',
290 ], 296 ],
291 }, 297 },
292 'cflags': [ 298 'cflags': [
293 # Since ICU wants to internally use its own deprecated APIs, 299 # Since ICU wants to internally use its own deprecated APIs,
294 # don't complain about it. 300 # don't complain about it.
295 '-Wno-deprecated-declarations', 301 '-Wno-deprecated-declarations',
296 '-Wno-unused-function', 302 '-Wno-unused-function',
297 ], 303 ],
298 'cflags_cc': [ 304 'cflags_cc': [
299 '-frtti', 305 '-frtti',
(...skipping 283 matching lines...) Expand 10 before | Expand all | Expand 10 after
583 }, 589 },
584 'includes': [ 590 'includes': [
585 '../../build/shim_headers.gypi', 591 '../../build/shim_headers.gypi',
586 ], 592 ],
587 'toolsets': ['target'], 593 'toolsets': ['target'],
588 }, 594 },
589 ], # targets 595 ], # targets
590 }], 596 }],
591 ], # conditions 597 ], # conditions
592 } 598 }
OLDNEW
« BUILD.gn ('K') | « BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698