Suppress warnings for assignment inside conditionals.

BUILD.gn

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//third_party/icu/config.gni")
 
 # Meta target that includes both icuuc and icui18n. Most targets want both.
 # You can depend on the individually if you need to.
 group("icu") {
   deps = [
@@ skipping 53 matching lines @@
       "-Wno-deprecated-declarations",
       "-Wno-unused-function",
     ]
   }
   if (is_clang) {
     cflags += [
       "-Wno-deprecated-declarations",
       "-Wno-logical-op-parentheses",
       "-Wno-tautological-compare",
       "-Wno-switch",
-    ]
+      "-Wno-parentheses",
+      ]
     if (is_win) {
       cflags += [
         # See http://bugs.icu-project.org/trac/ticket/11122
         "-Wno-inline-new-delete",
         "-Wno-implicit-exception-spec-mismatch",
       ]
     }
   }
 }
 
@@ skipping 389 matching lines @@
     "source/common/utypes.c",
     "source/common/uvector.cpp",
     "source/common/uvectr32.cpp",
     "source/common/uvectr64.cpp",
     "source/common/wintz.c",
   ]
   defines = [ "U_COMMON_IMPLEMENTATION" ]
   deps = [
     ":icudata",
   ]
-  configs += [ ":icu_code" ]
 
   configs -= [
     "//build/config/compiler:no_rtti",  # ICU uses RTTI.
     "//build/config/compiler:chromium_code",
   ]
   configs += [
     "//build/config/compiler:rtti",
     "//build/config/compiler:no_chromium_code",
   ]
 
+  configs += [ ":icu_code" ]

[dcheng, 2015/06/30 21:18:09]

Apparently it wasn't really suppressing the warnings before. It is now =)

[Nico, 2015/06/30 21:32:58]

Ah cool. Yes, the += appends no_chromium_code to configs which adds -Wall, so
the compile command would end up with

  "-Wno-foo -Wall"

and Wfoo was part of Wall so Wall reenabled it. Now the -Wno-foo is passed after
-Wall.

This transformation isn't safe in general: If icu_code added include
directories, you'd want the icu_code directories to come in front of the general
include directories. Since it only contains defines and warning flags, this is a
good change however.

   public_configs = [ ":icu_config" ]
 
   if (is_win || icu_use_data_file) {
     sources += [ "source/stubdata/stubdata.c" ]
     defines += [ "U_ICUDATAENTRY_IN_COMMON" ]
   }
 }
 
 # TODO(GYP) support use_system_icu.
 if (icu_use_data_file) {
@@ skipping 57 matching lines @@
         sources = [
           "android/icudtl_dat.S",
         ]
       } else {
         assert(false, "No icu data for this platform")
       }
       defines = [ "U_HIDE_DATA_SYMBOL" ]
     }
   }
 }