Chromium Code Reviews

Issue 1209403005: Let the second pass phantom callbacks run in a separate task on the foreground thread. (Closed)

Created:
5 years, 5 months ago by epertoso
Modified:
5 years, 5 months ago
Reviewers:
jochen (gone - plz use gerrit)
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Let the second pass phantom callbacks run in a separate task on the foreground thread. R=jochen@chromium.org LOG=y BUG= Committed: https://crrev.com/e6e53390cc4c2765a9104fdbceed79cf41f07551 Cr-Commit-Position: refs/heads/master@{#29680}

Patch Set 1 #

Total comments: 2

Patch Set 2 : update #

Patch Set 3 : Update. #

Patch Set 4 : Renamed static function. #

Patch Set 5 : Fix tests. #

Patch Set 6 : Updates samples. #

Patch Set 7 : Run second pass callbacks synchronously when GC is forced. #

Unified diffs Side-by-side diffs Stats (+128 lines, -30 lines)
M include/v8-util.h View 3 chunks +5 lines, -2 lines 0 comments
M samples/process.cc View 2 chunks +7 lines, -5 lines 0 comments
M samples/shell.cc View 7 chunks +16 lines, -8 lines 0 comments
M src/d8.h View 1 chunk +1 line, -0 lines 0 comments
M src/d8.cc View 2 chunks +6 lines, -0 lines 0 comments
M src/global-handles.h View 2 chunks +8 lines, -3 lines 0 comments
M src/global-handles.cc View 5 chunks +52 lines, -11 lines 0 comments
M src/heap/heap.cc View 1 chunk +2 lines, -1 line 0 comments
M src/list.h View 2 chunks +5 lines, -0 lines 0 comments
M src/list-inl.h View 1 chunk +6 lines, -0 lines 0 comments
M test/cctest/cctest.h View 2 chunks +8 lines, -0 lines 0 comments
M test/cctest/cctest.cc View 1 chunk +1 line, -0 lines 0 comments
M test/cctest/test-api.cc View 5 chunks +6 lines, -0 lines 0 comments
M test/unittests/test-utils.cc View 2 chunks +5 lines, -0 lines 0 comments

Messages

Total messages: 31 (11 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209403005/1
5 years, 5 months ago (2015-07-03 12:41:59 UTC) #2
jochen (gone - plz use gerrit)
https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc#newcode525 src/global-handles.cc:525: }; nit. DISALLOW_COPY_AND_ASSIGN(PendingPhantomCallbacksSecondPassTask)
5 years, 5 months ago (2015-07-03 12:42:27 UTC) #3
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_asan_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_asan_rel/builds/5736)
5 years, 5 months ago (2015-07-03 13:11:04 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209403005/20001
5 years, 5 months ago (2015-07-03 14:36:13 UTC) #7
epertoso
https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc File src/global-handles.cc (right): https://codereview.chromium.org/1209403005/diff/1/src/global-handles.cc#newcode525 src/global-handles.cc:525: }; On 2015/07/03 at 12:42:27, jochen wrote: > nit. ...
5 years, 5 months ago (2015-07-03 14:38:00 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-03 15:01:12 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209403005/60001
5 years, 5 months ago (2015-07-10 08:03:14 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: v8_linux64_avx2_rel on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_linux64_avx2_rel/builds/2177) v8_linux_rel on ...
5 years, 5 months ago (2015-07-10 08:06:42 UTC) #14
jochen (gone - plz use gerrit)
can you add message queue pumping to the other binaries as well please (d8, unittests, ...
5 years, 5 months ago (2015-07-10 08:16:15 UTC) #15
epertoso
On 2015/07/10 at 08:16:15, jochen wrote: > can you add message queue pumping to the ...
5 years, 5 months ago (2015-07-10 12:40:35 UTC) #16
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209403005/100001
5 years, 5 months ago (2015-07-10 12:45:04 UTC) #18
jochen (gone - plz use gerrit)
lgtm
5 years, 5 months ago (2015-07-10 12:50:46 UTC) #19
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-10 13:14:43 UTC) #21
epertoso
On 2015/07/10 at 12:50:46, jochen wrote: > lgtm PTAL: the second pass phantom callbacks are ...
5 years, 5 months ago (2015-07-13 15:31:00 UTC) #22
jochen (gone - plz use gerrit)
still lgtm
5 years, 5 months ago (2015-07-14 14:14:02 UTC) #23
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209403005/120001
5 years, 5 months ago (2015-07-14 14:14:16 UTC) #25
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-14 14:57:16 UTC) #27
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1209403005/120001
5 years, 5 months ago (2015-07-15 12:24:39 UTC) #29
commit-bot: I haz the power
Committed patchset #7 (id:120001)
5 years, 5 months ago (2015-07-15 12:26:10 UTC) #30
commit-bot: I haz the power
5 years, 5 months ago (2015-07-15 12:26:19 UTC) #31
Message was sent while issue was closed. 
Patchset 7 (id:??) landed as
https://crrev.com/e6e53390cc4c2765a9104fdbceed79cf41f07551
Cr-Commit-Position: refs/heads/master@{#29680}

Powered by Google App Engine