Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Unified Diff: test/unittests/test-utils.cc

Issue 1209403005: Let the second pass phantom callbacks run in a separate task on the foreground thread. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Run second pass callbacks synchronously when GC is forced. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: test/unittests/test-utils.cc
diff --git a/test/unittests/test-utils.cc b/test/unittests/test-utils.cc
index 522ee1293046cdb50863a498cff6fcf2fb27a846..93a46ed15d50c70221746293251953f2979066b1 100644
--- a/test/unittests/test-utils.cc
+++ b/test/unittests/test-utils.cc
@@ -4,10 +4,12 @@
#include "test/unittests/test-utils.h"
+#include "include/libplatform/libplatform.h"
#include "src/base/platform/time.h"
#include "src/debug.h"
#include "src/flags.h"
#include "src/isolate.h"
+#include "src/v8.h"
namespace v8 {
@@ -51,6 +53,9 @@ void TestWithIsolate::SetUpTestCase() {
// static
void TestWithIsolate::TearDownTestCase() {
ASSERT_TRUE(isolate_ != NULL);
+ v8::Platform* platform = internal::V8::GetCurrentPlatform();
+ ASSERT_TRUE(platform != NULL);
+ while (platform::PumpMessageLoop(platform, isolate_)) continue;
isolate_->Dispose();
isolate_ = NULL;
delete array_buffer_allocator_;
« no previous file with comments | « test/cctest/test-api.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698