src/heap/heap.cc - Issue 1209403005: Let the second pass phantom callbacks run in a separate task on the foreground thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/heap/heap.cc

Issue 1209403005: Let the second pass phantom callbacks run in a separate task on the foreground thread. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Run second pass callbacks synchronously when GC is forced. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/heap/heap.cc

diff --git a/src/heap/heap.cc b/src/heap/heap.cc

index eef37429aad3a4be453517f52c6efc5402bcd203..3340a0fd384a3cdf8bb9e11a90b00f9f00b3b249 100644

--- a/src/heap/heap.cc

+++ b/src/heap/heap.cc

@@ -1306,7 +1306,8 @@ bool Heap::PerformGarbageCollection(

AllowHeapAllocation allow_allocation;

GCTracer::Scope scope(tracer(), GCTracer::Scope::EXTERNAL);

freed_global_handles =

- isolate_->global_handles()->PostGarbageCollectionProcessing(collector);

+ isolate_->global_handles()->PostGarbageCollectionProcessing(

+ collector, gc_callback_flags);

}

gc_post_processing_depth_--;

« no previous file with comments | « src/global-handles.cc ('k') | src/list.h » ('j') | no next file with comments »