Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Unified Diff: components/autofill/core/common/password_form.h

Issue 1209363003: Rename avatar to icon in the credential manager in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added TODO. Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | components/password_manager/content/common/credential_manager_content_utils.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/autofill/core/common/password_form.h
diff --git a/components/autofill/core/common/password_form.h b/components/autofill/core/common/password_form.h
index 11c1e2f6d2ad965b6bc6fcbbd6e2f366059a0b9d..95d138f97d951900e23e8902f6f73a321b20abfc 100644
--- a/components/autofill/core/common/password_form.h
+++ b/components/autofill/core/common/password_form.h
@@ -248,7 +248,10 @@ struct PasswordForm {
// User friendly name to show in the UI.
base::string16 display_name;
- // The URL of the user's avatar to display in the UI.
+ // The URL of the user's avatar to display in the UI. Note that the
+ // corresponding property in the Credential Manager is called icon URL.
+ // TODO(msramek): Rename |avatar_url| to |icon_url| to match the naming
+ // in Credential Manager.
GURL avatar_url;
// The URL of identity provider used for federated login.
« no previous file with comments | « no previous file | components/password_manager/content/common/credential_manager_content_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698