Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(509)

Side by Side Diff: components/autofill/core/common/password_form.h

Issue 1209363003: Rename avatar to icon in the credential manager in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added TODO. Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/password_manager/content/common/credential_manager_content_utils.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 5 #ifndef COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 6 #define COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
7 7
8 #include <map> 8 #include <map>
9 #include <string> 9 #include <string>
10 #include <vector> 10 #include <vector>
(...skipping 230 matching lines...) Expand 10 before | Expand all | Expand 10 after
241 // What information has been sent to the Autofill server about this form. 241 // What information has been sent to the Autofill server about this form.
242 GenerationUploadStatus generation_upload_status; 242 GenerationUploadStatus generation_upload_status;
243 243
244 // These following fields are set by a website using the Credential Manager 244 // These following fields are set by a website using the Credential Manager
245 // API. They will be empty and remain unused for sites which do not use that 245 // API. They will be empty and remain unused for sites which do not use that
246 // API. 246 // API.
247 // 247 //
248 // User friendly name to show in the UI. 248 // User friendly name to show in the UI.
249 base::string16 display_name; 249 base::string16 display_name;
250 250
251 // The URL of the user's avatar to display in the UI. 251 // The URL of the user's avatar to display in the UI. Note that the
252 // corresponding property in the Credential Manager is called icon URL.
253 // TODO(msramek): Rename |avatar_url| to |icon_url| to match the naming
254 // in Credential Manager.
252 GURL avatar_url; 255 GURL avatar_url;
253 256
254 // The URL of identity provider used for federated login. 257 // The URL of identity provider used for federated login.
255 GURL federation_url; 258 GURL federation_url;
256 259
257 // If true, Chrome will not return this credential to a site in response to 260 // If true, Chrome will not return this credential to a site in response to
258 // 'navigator.credentials.request()' without user interaction. 261 // 'navigator.credentials.request()' without user interaction.
259 // Once user selects this credential the flag is reseted. 262 // Once user selects this credential the flag is reseted.
260 bool skip_zero_click; 263 bool skip_zero_click;
261 264
(...skipping 27 matching lines...) Expand all
289 typedef std::map<base::string16, const PasswordForm*> ConstPasswordFormMap; 292 typedef std::map<base::string16, const PasswordForm*> ConstPasswordFormMap;
290 293
291 // For testing. 294 // For testing.
292 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout); 295 std::ostream& operator<<(std::ostream& os, PasswordForm::Layout layout);
293 std::ostream& operator<<(std::ostream& os, const autofill::PasswordForm& form); 296 std::ostream& operator<<(std::ostream& os, const autofill::PasswordForm& form);
294 std::ostream& operator<<(std::ostream& os, autofill::PasswordForm* form); 297 std::ostream& operator<<(std::ostream& os, autofill::PasswordForm* form);
295 298
296 } // namespace autofill 299 } // namespace autofill
297 300
298 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__ 301 #endif // COMPONENTS_AUTOFILL_CORE_COMMON_PASSWORD_FORM_H__
OLDNEW
« no previous file with comments | « no previous file | components/password_manager/content/common/credential_manager_content_utils.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698