components/password_manager/content/common/credential_manager_content_utils.cc - Issue 1209363003: Rename avatar to icon in the credential manager in Chromium.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/content/common/credential_manager_content_utils.cc

Issue 1209363003: Rename avatar to icon in the credential manager in Chromium. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Added TODO. Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/core/common/password_form.h ('k') | components/password_manager/content/common/credential_manager_messages.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/content/common/credential_manager_content_utils.cc

diff --git a/components/password_manager/content/common/credential_manager_content_utils.cc b/components/password_manager/content/common/credential_manager_content_utils.cc

index ce3d6cf6d1040c517e76190a74869cf4bdd3a279..937182ef9270c3e63736744a0518c9fc6bfb0dbf 100644

--- a/components/password_manager/content/common/credential_manager_content_utils.cc

+++ b/components/password_manager/content/common/credential_manager_content_utils.cc

@@ -16,7 +16,7 @@ CredentialInfo WebCredentialToCredentialInfo(

CredentialInfo credential_info;

credential_info.id = credential.id();

credential_info.name = credential.name();

- credential_info.avatar = credential.avatarURL();

+ credential_info.icon = credential.iconURL();

credential_info.type = credential.isPasswordCredential()

? CredentialType::CREDENTIAL_TYPE_PASSWORD

: CredentialType::CREDENTIAL_TYPE_FEDERATED;