Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed)

Created:
7 years, 10 months ago by Yoyo Zhou
Modified:
7 years, 10 months ago
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, dmazzoni+watch_chromium.org, rouslan+watch_chromium.org, vsevik, aboxhall+watch_chromium.org, stevenjb+watch_chromium.org, darin-cc_chromium.org, gbillock+watch_chromium.org, chromium-apps-reviews_chromium.org, groby+watch_chromium.org, yuzo+watch_chromium.org, oshima+watch_chromium.org, ctguil+watch_chromium.org, zork+watch_chromium.org, hashimoto+watch_chromium.org, yurys, davidbarr+watch_chromium.org, Aaron Boodman, davemoore+watch_chromium.org, dtseng+watch_chromium.org, smckay+watch_chromium.org, pfeldman, mhx348_motorola.com
Visibility:
Public.

Description

Allow manifest handlers to declare keys they depend on that must be parsed before them. Also fixes linked_ptr usage for multi-key handlers. BUG=159265 TBR=ben@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=180575

Patch Set 1 #

Total comments: 1

Patch Set 2 : rebase #

Total comments: 4

Patch Set 3 : keys #

Total comments: 6

Patch Set 4 : mp #

Patch Set 5 : y #

Patch Set 6 : #

Total comments: 10

Patch Set 7 : dcronin #

Unified diffs Side-by-side diffs Delta from patch set Stats (+391 lines, -82 lines) Patch
M chrome/browser/chromeos/extensions/file_browser_manifest_unittest.cc View 1 2 3 4 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_private_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/extensions/file_browser_resource_throttle_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/commands/command_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/extension_action/extension_action_api.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/extensions/api/file_handlers/file_handlers_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/i18n/i18n_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_api.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/identity/identity_apitest.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/input_ime/input_ime_api.cc View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/api/omnibox/omnibox_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/extension_service_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/extensions/extension_special_storage_policy_unittest.cc View 1 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/manifest_url_parser.cc View 1 chunk +5 lines, -5 lines 0 comments Download
M chrome/browser/extensions/sandboxed_unpacker_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/updater/extension_updater_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/extensions/web_accessible_resources_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/web_intents_parser.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/intents/web_intents_registry_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/speech/extension_api/tts_extension_api.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/commands/commands_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/browser_action_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_action/script_badge_manifest_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/i18n/default_locale_manifest_unittest.cc View 1 2 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/common/extensions/api/identity/extension_manifests_auth_unittest.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/extension_file_util_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/extension_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_handler.h View 2 chunks +12 lines, -1 line 0 comments Download
M chrome/common/extensions/manifest_handler.cc View 1 2 3 4 5 6 4 chunks +105 lines, -15 lines 0 comments Download
A chrome/common/extensions/manifest_handler_unittest.cc View 1 2 3 4 5 6 1 chunk +190 lines, -0 lines 0 comments Download
chrome/common/extensions/manifest_tests/extension_manifest_test.h View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
chrome/common/extensions/manifest_tests/extension_manifest_test.cc View 2 chunks +5 lines, -0 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_background_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_devtools_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
chrome/common/extensions/manifest_tests/extension_manifests_homepage_unittest.cc View 1 chunk +6 lines, -4 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_initvalue_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_options_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_override_unittest.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_ui_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_update_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_accessible_resources_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/manifest_tests/extension_manifests_web_intents_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/common/extensions/unpacker_unittest.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/renderer/chrome_content_renderer_client.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/utility/chrome_content_utility_client.cc View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Yoyo Zhou
Note that nobody has any dependent keys yet, although some could be added right now, ...
7 years, 10 months ago (2013-02-01 22:16:42 UTC) #1
Matt Perry
https://codereview.chromium.org/12091115/diff/5002/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/5002/chrome/common/extensions/manifest_handler.cc#newcode97 chrome/common/extensions/manifest_handler.cc:97: unsorted_handlers.begin(); I think this would be easier to follow ...
7 years, 10 months ago (2013-02-01 23:22:37 UTC) #2
Yoyo Zhou
https://codereview.chromium.org/12091115/diff/5002/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/5002/chrome/common/extensions/manifest_handler.cc#newcode97 chrome/common/extensions/manifest_handler.cc:97: unsorted_handlers.begin(); On 2013/02/01 23:22:37, Matt Perry wrote: > I ...
7 years, 10 months ago (2013-02-02 00:32:22 UTC) #3
Matt Perry
lgtm https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc#newcode107 chrome/common/extensions/manifest_handler.cc:107: // Nonexistent prerequisite; ignore it. Shouldn't this be ...
7 years, 10 months ago (2013-02-02 00:58:58 UTC) #4
Yoyo Zhou
https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc#newcode107 chrome/common/extensions/manifest_handler.cc:107: // Nonexistent prerequisite; ignore it. On 2013/02/02 00:58:58, Matt ...
7 years, 10 months ago (2013-02-02 02:26:45 UTC) #5
Matt Perry
https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc#newcode132 chrome/common/extensions/manifest_handler.cc:132: << "circular dependencies:"; On 2013/02/02 02:26:45, Yoyo Zhou wrote: ...
7 years, 10 months ago (2013-02-02 02:29:02 UTC) #6
Yoyo Zhou
https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/5006/chrome/common/extensions/manifest_handler.cc#newcode132 chrome/common/extensions/manifest_handler.cc:132: << "circular dependencies:"; On 2013/02/02 02:29:03, Matt Perry wrote: ...
7 years, 10 months ago (2013-02-02 02:38:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12091115/46002
7 years, 10 months ago (2013-02-02 02:46:27 UTC) #8
commit-bot: I haz the power
Presubmit check for 12091115-46002 failed and returned exit status 1. Running presubmit commit checks ...
7 years, 10 months ago (2013-02-02 02:46:47 UTC) #9
Yoyo Zhou
TBR=ben for uninteresting refactoring changes
7 years, 10 months ago (2013-02-02 02:52:47 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12091115/46002
7 years, 10 months ago (2013-02-02 02:55:02 UTC) #11
Devlin
https://codereview.chromium.org/12091115/diff/50001/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/50001/chrome/common/extensions/manifest_handler.cc#newcode37 chrome/common/extensions/manifest_handler.cc:37: // Manifest handlers with circular dependencies are unregistered. nit: ...
7 years, 10 months ago (2013-02-02 21:41:37 UTC) #12
Yoyo Zhou
https://codereview.chromium.org/12091115/diff/50001/chrome/common/extensions/manifest_handler.cc File chrome/common/extensions/manifest_handler.cc (right): https://codereview.chromium.org/12091115/diff/50001/chrome/common/extensions/manifest_handler.cc#newcode37 chrome/common/extensions/manifest_handler.cc:37: // Manifest handlers with circular dependencies are unregistered. On ...
7 years, 10 months ago (2013-02-04 20:24:30 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12091115/48003
7 years, 10 months ago (2013-02-04 20:26:33 UTC) #14
commit-bot: I haz the power
Sorry for I got bad news for ya. Compile failed with a clobber build on ...
7 years, 10 months ago (2013-02-04 21:27:59 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoz@chromium.org/12091115/48003
7 years, 10 months ago (2013-02-04 23:16:56 UTC) #16
commit-bot: I haz the power
7 years, 10 months ago (2013-02-05 00:26:29 UTC) #17
Message was sent while issue was closed.
Change committed as 180575

Powered by Google App Engine
This is Rietveld 408576698