Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Side by Side Diff: chrome/common/extensions/manifest_tests/extension_manifests_launch_unittest.cc

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dcronin Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h" 5 #include "chrome/common/extensions/manifest_tests/extension_manifest_test.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "chrome/common/extensions/extension.h" 9 #include "chrome/common/extensions/extension.h"
10 #include "chrome/common/extensions/extension_manifest_constants.h" 10 #include "chrome/common/extensions/extension_manifest_constants.h"
11 #include "extensions/common/error_utils.h" 11 #include "extensions/common/error_utils.h"
12 #include "testing/gtest/include/gtest/gtest.h" 12 #include "testing/gtest/include/gtest/gtest.h"
13 13
14 namespace errors = extension_manifest_errors; 14 namespace errors = extension_manifest_errors;
15 namespace keys = extension_manifest_keys;
15 16
16 using extensions::ErrorUtils; 17 using extensions::ErrorUtils;
17 18
18 TEST_F(ExtensionManifestTest, AppLaunchContainer) { 19 TEST_F(ExtensionManifestTest, AppLaunchContainer) {
19 scoped_refptr<extensions::Extension> extension; 20 scoped_refptr<extensions::Extension> extension;
20 21
21 extension = LoadAndExpectSuccess("launch_tab.json"); 22 extension = LoadAndExpectSuccess("launch_tab.json");
22 EXPECT_EQ(extension_misc::LAUNCH_TAB, extension->launch_container()); 23 EXPECT_EQ(extension_misc::LAUNCH_TAB, extension->launch_container());
23 24
24 extension = LoadAndExpectSuccess("launch_panel.json"); 25 extension = LoadAndExpectSuccess("launch_panel.json");
(...skipping 89 matching lines...) Expand 10 before | Expand all | Expand 10 after
114 errors::kInvalidLaunchValue, 115 errors::kInvalidLaunchValue,
115 keys::kLaunchWebURL)); 116 keys::kLaunchWebURL));
116 117
117 extension = LoadAndExpectSuccess("launch_web_url_absolute.json"); 118 extension = LoadAndExpectSuccess("launch_web_url_absolute.json");
118 EXPECT_EQ(GURL("http://www.google.com/launch.html"), 119 EXPECT_EQ(GURL("http://www.google.com/launch.html"),
119 extension->GetFullLaunchURL()); 120 extension->GetFullLaunchURL());
120 extension = LoadAndExpectSuccess("launch_web_url_localized.json"); 121 extension = LoadAndExpectSuccess("launch_web_url_localized.json");
121 EXPECT_EQ(GURL("http://www.google.com/launch.html"), 122 EXPECT_EQ(GURL("http://www.google.com/launch.html"),
122 extension->GetFullLaunchURL()); 123 extension->GetFullLaunchURL());
123 } 124 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698