Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(443)

Side by Side Diff: chrome/browser/extensions/updater/extension_updater_unittest.cc

Issue 12091115: Allow manifest handlers to declare keys they depend on that must be parsed before them. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: dcronin Created 7 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <list> 5 #include <list>
6 #include <map> 6 #include <map>
7 #include <set> 7 #include <set>
8 #include <vector> 8 #include <vector>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 440 matching lines...) Expand 10 before | Expand all | Expand 10 after
451 : ui_thread_(BrowserThread::UI, &loop_), 451 : ui_thread_(BrowserThread::UI, &loop_),
452 file_thread_(BrowserThread::FILE, &loop_), 452 file_thread_(BrowserThread::FILE, &loop_),
453 io_thread_(BrowserThread::IO, &loop_) { 453 io_thread_(BrowserThread::IO, &loop_) {
454 } 454 }
455 455
456 virtual ~ExtensionUpdaterTest() { 456 virtual ~ExtensionUpdaterTest() {
457 } 457 }
458 458
459 virtual void SetUp() OVERRIDE { 459 virtual void SetUp() OVERRIDE {
460 prefs_.reset(new TestExtensionPrefs(loop_.message_loop_proxy())); 460 prefs_.reset(new TestExtensionPrefs(loop_.message_loop_proxy()));
461 extensions::ManifestHandler::Register(extension_manifest_keys::kUpdateURL, 461 extensions::ManifestHandler::Register(
462 new extensions::UpdateURLHandler); 462 extension_manifest_keys::kUpdateURL,
463 make_linked_ptr(new extensions::UpdateURLHandler));
463 } 464 }
464 465
465 virtual void TearDown() OVERRIDE { 466 virtual void TearDown() OVERRIDE {
466 // Some tests create URLRequestContextGetters, whose destruction must run 467 // Some tests create URLRequestContextGetters, whose destruction must run
467 // on the IO thread. Make sure the IO loop spins before shutdown so that 468 // on the IO thread. Make sure the IO loop spins before shutdown so that
468 // those objects are released. 469 // those objects are released.
469 RunUntilIdle(); 470 RunUntilIdle();
470 prefs_.reset(); 471 prefs_.reset();
471 } 472 }
472 473
(...skipping 1220 matching lines...) Expand 10 before | Expand all | Expand 10 after
1693 // -prodversionmin (shouldn't update if browser version too old) 1694 // -prodversionmin (shouldn't update if browser version too old)
1694 // -manifests & updates arriving out of order / interleaved 1695 // -manifests & updates arriving out of order / interleaved
1695 // -malformed update url (empty, file://, has query, has a # fragment, etc.) 1696 // -malformed update url (empty, file://, has query, has a # fragment, etc.)
1696 // -An extension gets uninstalled while updates are in progress (so it doesn't 1697 // -An extension gets uninstalled while updates are in progress (so it doesn't
1697 // "come back from the dead") 1698 // "come back from the dead")
1698 // -An extension gets manually updated to v3 while we're downloading v2 (ie 1699 // -An extension gets manually updated to v3 while we're downloading v2 (ie
1699 // you don't get downgraded accidentally) 1700 // you don't get downgraded accidentally)
1700 // -An update manifest mentions multiple updates 1701 // -An update manifest mentions multiple updates
1701 1702
1702 } // namespace extensions 1703 } // namespace extensions
OLDNEW
« no previous file with comments | « chrome/browser/extensions/sandboxed_unpacker_unittest.cc ('k') | chrome/browser/extensions/web_accessible_resources_parser.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698