Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(404)

Issue 12087062: Revert 141139 (Closed)

Created:
7 years, 10 months ago by kerz_chromium
Modified:
7 years, 10 months ago
Reviewers:
kerz_chromium
CC:
chromium-reviews
Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/1364/
Visibility:
Public.

Description

Revert 141139 > Merge 140202 > > Fix scrollRectToVisible in the presence of transforms > > https://bugs.webkit.org/show_bug.cgi?id=105574 > > > > Patch by Chris Hopman <cjhopman@google.com>; on 2013-01-18 > > Reviewed by Simon Fraser. > > > > Source/WebCore: > > > > When scrolling to reveal an overflow layer, the required scroll was > > being calculated in absolute coordinates. To properly account for > > transforms, this calculation should be done in the local coordinates > > of the renderBox. > > > > Tests: editing/input/reveal-selection-transformed-overflow-parent.html > > editing/input/reveal-selection-transformed-textarea.html > > > > * rendering/RenderLayer.cpp: > > (WebCore::RenderLayer::scrollRectToVisible): > > When scrolling to reveal an overflow layer, calculate the required > > scroll in the local coordinates of the RenderBox. > > * rendering/RenderObject.cpp: > > (WebCore::RenderObject::absoluteToLocalQuad): > > (WebCore): > > * rendering/RenderObject.h: > > (RenderObject): > > Add function to convert an absolute quad to a local quad. > > > > LayoutTests: > > > > * editing/input/reveal-caret-of-transformed-input-scrollable-parent.html: Added. > > * editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added. > > Test that when scrolling an overflow layer to reveal a rect, the rect > > passed to the parent to scroll is calculated properly. > > * editing/input/reveal-caret-of-transformed-multiline-input.html: Added. > > * editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added. > > Test that scrolling to reveal a rect works properly on a transformed > > overflow layer. > > > > * platform/chromium/TestExpectations: > > * platform/mac/TestExpectations: > > TBR=commit-queue@webkit.org > Review URL: https://codereview.chromium.org/12084049 TBR=kerz@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141158

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+619 lines, -10326 lines) Patch
D LayoutTests/editing/input/reveal-caret-of-transformed-input-scrollable-parent.html View 1 chunk +0 lines, -30 lines 0 comments Download
D LayoutTests/editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/editing/input/reveal-caret-of-transformed-multiline-input.html View 1 chunk +0 lines, -24 lines 0 comments Download
D LayoutTests/editing/input/reveal-caret-of-transformed-multiline-input-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/platform/chromium/TestExpectations View 1 chunk +0 lines, -89 lines 0 comments Download
M LayoutTests/platform/mac/TestExpectations View 1 chunk +609 lines, -662 lines 0 comments Download
M Source/WebCore/ChangeLog View 1 chunk +0 lines, -9501 lines 0 comments Download
M Source/WebCore/rendering/RenderLayer.cpp View 2 chunks +10 lines, -8 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.h View 1 chunk +0 lines, -2 lines 0 comments Download
M Source/WebCore/rendering/RenderObject.cpp View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
kerz_chromium
7 years, 10 months ago (2013-01-29 21:16:39 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698