 Chromium Code Reviews
 Chromium Code Reviews Issue 
            12084049:
    Merge 140202  (Closed)
    
  
    Issue 
            12084049:
    Merge 140202  (Closed) 
  | DescriptionMerge 140202
> Fix scrollRectToVisible in the presence of transforms
> https://bugs.webkit.org/show_bug.cgi?id=105574
> 
> Patch by Chris Hopman <cjhopman@google.com> on 2013-01-18
> Reviewed by Simon Fraser.
> 
> Source/WebCore:
> 
> When scrolling to reveal an overflow layer, the required scroll was
> being calculated in absolute coordinates. To properly account for
> transforms, this calculation should be done in the local coordinates
> of the renderBox.
> 
> Tests: editing/input/reveal-selection-transformed-overflow-parent.html
>        editing/input/reveal-selection-transformed-textarea.html
> 
> * rendering/RenderLayer.cpp:
> (WebCore::RenderLayer::scrollRectToVisible):
> When scrolling to reveal an overflow layer, calculate the required
> scroll in the local coordinates of the RenderBox.
> * rendering/RenderObject.cpp:
> (WebCore::RenderObject::absoluteToLocalQuad):
> (WebCore):
> * rendering/RenderObject.h:
> (RenderObject):
> Add function to convert an absolute quad to a local quad.
> 
> LayoutTests:
> 
> * editing/input/reveal-caret-of-transformed-input-scrollable-parent.html: Added.
> * editing/input/reveal-caret-of-transformed-input-scrollable-parent-expected.txt: Added.
> Test that when scrolling an overflow layer to reveal a rect, the rect
> passed to the parent to scroll is calculated properly.
> * editing/input/reveal-caret-of-transformed-multiline-input.html: Added.
> * editing/input/reveal-caret-of-transformed-multiline-input-expected.txt: Added.
> Test that scrolling to reveal a rect works properly on a transformed
> overflow layer.
> 
> * platform/chromium/TestExpectations:
> * platform/mac/TestExpectations:
TBR=commit-queue@webkit.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=141139
   Patch Set 1 #
      Created: 7 years, 10 months ago
     
      
        (Patch set is too large to download)
      
     Messages
    Total messages: 1 (0 generated)
     |