chrome/android/java/strings/android_chrome_strings.grd - Issue 1208503002: Let product name be visible in app menu of custom tabs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/strings/android_chrome_strings.grd

Issue 1208503002: Let product name be visible in app menu of custom tabs (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/res/menu/custom_tabs_menu.xml ('k') | chrome/android/java_staging/src/org/chromium/chrome/browser/customtabs/CustomTabAppMenuPropertiesDelegate.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/strings/android_chrome_strings.grd

diff --git a/chrome/android/java/strings/android_chrome_strings.grd b/chrome/android/java/strings/android_chrome_strings.grd

index b3456b94677e01a808252d2ac85ea228dc42b55b..7333928226ee7e64c9f3bae11cbe8a464a2060ad 100644

--- a/chrome/android/java/strings/android_chrome_strings.grd

+++ b/chrome/android/java/strings/android_chrome_strings.grd

@@ -1930,6 +1930,9 @@ Just open Chrome on your computer, go to the menu, and select “Sign in to Chro

newt (away) 2015/06/24 18:03:50 can we delete this string now?

Ian Wen 2015/06/24 18:13:00 I am afraid that we can't delete it. Context menu

Open in Chrome

</message>

+ <message name="IDS_MENU_OPEN_IN_PRODUCT" desc="App menu item for opening link in Chrome. [CHAR-LIMIT=30]">

+ Open in <ph name="PRODUCT_NAME">%1$s<ex>Chrome</ex></ph>

+ </message>

Text selection

</message>