Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Issue 1208363002: clang/win: Don't pass -Wno-inconsistent-missing-override twice. (Closed)

Created:
5 years, 6 months ago by Nico
Modified:
5 years, 6 months ago
Reviewers:
hans
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang/win: Don't pass -Wno-inconsistent-missing-override twice. It's already passed unconditionally everywhere if clang is used, there's no need to pass it again for clang/win. BUG=82385, 428099 Committed: https://crrev.com/e0ad0cfd95a0e90bcfb817168cade7bd1143ada4 Cr-Commit-Position: refs/heads/master@{#336431}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -4 lines) Patch
M build/common.gypi View 1 2 chunks +1 line, -2 lines 0 comments Download
M build/config/compiler/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
Nico
5 years, 6 months ago (2015-06-26 01:04:55 UTC) #2
hans
lgtm I suppose we hit this earlier on Windows because we used ToT, and then ...
5 years, 6 months ago (2015-06-26 15:21:23 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1208363002/20001
5 years, 6 months ago (2015-06-26 16:53:03 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 6 months ago (2015-06-26 19:00:09 UTC) #7
commit-bot: I haz the power
5 years, 6 months ago (2015-06-26 19:01:05 UTC) #8
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e0ad0cfd95a0e90bcfb817168cade7bd1143ada4
Cr-Commit-Position: refs/heads/master@{#336431}

Powered by Google App Engine
This is Rietveld 408576698