Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(125)

Side by Side Diff: build/config/compiler/BUILD.gn

Issue 1208363002: clang/win: Don't pass -Wno-inconsistent-missing-override twice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//build/config/android/config.gni") 5 import("//build/config/android/config.gni")
6 import("//build/config/chrome_build.gni") 6 import("//build/config/chrome_build.gni")
7 if (current_cpu == "arm") { 7 if (current_cpu == "arm") {
8 import("//build/config/arm.gni") 8 import("//build/config/arm.gni")
9 } 9 }
10 if (current_cpu == "mipsel" || current_cpu == "mips64el") { 10 if (current_cpu == "mipsel" || current_cpu == "mips64el") {
(...skipping 812 matching lines...) Expand 10 before | Expand all | Expand 10 after
823 "-Wno-sometimes-uninitialized", 823 "-Wno-sometimes-uninitialized",
824 "-Wno-switch", 824 "-Wno-switch",
825 "-Wno-tautological-compare", 825 "-Wno-tautological-compare",
826 "-Wno-unknown-pragmas", 826 "-Wno-unknown-pragmas",
827 "-Wno-unsequenced", 827 "-Wno-unsequenced",
828 "-Wno-unused-function", 828 "-Wno-unused-function",
829 "-Wno-unused-private-field", 829 "-Wno-unused-private-field",
830 "-Wno-unused-value", 830 "-Wno-unused-value",
831 "-Wno-unused-variable", 831 "-Wno-unused-variable",
832 "-Wno-unused-local-typedef", # http://crbug.com/411648 832 "-Wno-unused-local-typedef", # http://crbug.com/411648
833 "-Wno-inconsistent-missing-override", #http://crbug.com/428099
834 ] 833 ]
835 } 834 }
836 } else { 835 } else {
837 # Common GCC warning setup. 836 # Common GCC warning setup.
838 default_warning_flags += [ 837 default_warning_flags += [
839 # Enables. 838 # Enables.
840 "-Wendif-labels", # Weird old-style text after an #endif. 839 "-Wendif-labels", # Weird old-style text after an #endif.
841 "-Werror", # Warnings as errors. 840 "-Werror", # Warnings as errors.
842 841
843 # Disables. 842 # Disables.
(...skipping 86 matching lines...) Expand 10 before | Expand all | Expand 10 after
930 # TODO(thakis): Remove, http://crbug.com/263960 929 # TODO(thakis): Remove, http://crbug.com/263960
931 "-Wno-reserved-user-defined-literal", 930 "-Wno-reserved-user-defined-literal",
932 ] 931 ]
933 932
934 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost 933 # NaCl's Clang compiler and Chrome's hermetic Clang compiler will almost
935 # always have different versions. Certain flags may not be recognized by 934 # always have different versions. Certain flags may not be recognized by
936 # one version or the other. 935 # one version or the other.
937 if (!is_nacl) { 936 if (!is_nacl) {
938 # Flags NaCl does not recognize. 937 # Flags NaCl does not recognize.
939 default_warning_flags += [ 938 default_warning_flags += [
940 # TODO(hans): Get this cleaned up. 939 # TODO(hans): Get this cleaned up, http://crbug.com/428099
941 "-Wno-inconsistent-missing-override", 940 "-Wno-inconsistent-missing-override",
942 ] 941 ]
943 } 942 }
944 } 943 }
945 944
946 # chromium_code --------------------------------------------------------------- 945 # chromium_code ---------------------------------------------------------------
947 # 946 #
948 # Toggles between higher and lower warnings for code that is (or isn't) 947 # Toggles between higher and lower warnings for code that is (or isn't)
949 # part of Chromium. 948 # part of Chromium.
950 949
(...skipping 296 matching lines...) Expand 10 before | Expand all | Expand 10 after
1247 cflags += [ "-gsplit-dwarf" ] 1246 cflags += [ "-gsplit-dwarf" ]
1248 } 1247 }
1249 } 1248 }
1250 } 1249 }
1251 1250
1252 config("no_symbols") { 1251 config("no_symbols") {
1253 if (!is_win) { 1252 if (!is_win) {
1254 cflags = [ "-g0" ] 1253 cflags = [ "-g0" ]
1255 } 1254 }
1256 } 1255 }
OLDNEW
« no previous file with comments | « build/common.gypi ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698