build/common.gypi - Issue 1208363002: clang/win: Don't pass -Wno-inconsistent-missing-override twice.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/common.gypi

Issue 1208363002: clang/win: Don't pass -Wno-inconsistent-missing-override twice. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: build/common.gypi

diff --git a/build/common.gypi b/build/common.gypi

index d03bc4a42630cb12b33c3b552d0e2105ea479d4d..65ff24aab1b30acb127bc9d3583141890c5bdd98 100644

--- a/build/common.gypi

+++ b/build/common.gypi

@@ -2592,7 +2592,7 @@

# http://crbug.com/255186

'-Wno-deprecated-register',

- # TODO(hans): Get this cleaned up.

+ # TODO(hans): Get this cleaned up, http://crbug.com/428099

'-Wno-inconsistent-missing-override',

@@ -5731,7 +5731,6 @@

'-Wno-unused-value',

'-Wno-unused-variable',

'-Wno-unused-local-typedef', # http://crbug.com/411648

- '-Wno-inconsistent-missing-override', # http://crbug.com/428099

}],

« no previous file with comments | « no previous file | build/config/compiler/BUILD.gn » ('j') | no next file with comments »