Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 1206673006: Don't use base::WorkerPool in the asset_bundle app. (Closed)

Created:
5 years, 6 months ago by viettrungluu
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org, yzshen+watch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Don't use base::WorkerPool in the asset_bundle app. WorkerPools can't be shut down, which means that the app's .so can't be unloaded (which is bad for single process mode, and which is probably why the asset bundle tests are flakily crashing on the try bots). So use a SequencedWorkerPool instead (even though we don't care about sequencing). R=eseidel@chromium.org, kulakowski@chromium.org, abarth@chromium.org BUG=Fixes #268 Committed: https://chromium.googlesource.com/external/mojo/+/08c72e1bad0fdaa71bb356749bb9b548ac18a174

Patch Set 1 #

Total comments: 2

Patch Set 2 : move comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+57 lines, -25 lines) Patch
M services/asset_bundle/asset_bundle_impl.h View 3 chunks +4 lines, -1 line 0 comments Download
M services/asset_bundle/asset_bundle_impl.cc View 3 chunks +7 lines, -7 lines 0 comments Download
M services/asset_bundle/asset_unpacker_impl.h View 3 chunks +5 lines, -1 line 0 comments Download
M services/asset_bundle/asset_unpacker_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M services/asset_bundle/asset_unpacker_job.h View 3 chunks +4 lines, -1 line 0 comments Download
M services/asset_bundle/asset_unpacker_job.cc View 4 chunks +10 lines, -10 lines 0 comments Download
M services/asset_bundle/main.cc View 1 2 chunks +19 lines, -1 line 0 comments Download
M sky/shell/ui/internals.cc View 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 8 (1 generated)
viettrungluu
5 years, 6 months ago (2015-06-24 19:58:01 UTC) #1
eseidel
abarth is definitely a better reviewer for this than I am. But in his absence, ...
5 years, 6 months ago (2015-06-24 22:16:09 UTC) #2
kulakowski
lgtm
5 years, 6 months ago (2015-06-24 22:17:32 UTC) #4
kulakowski
https://codereview.chromium.org/1206673006/diff/1/services/asset_bundle/main.cc File services/asset_bundle/main.cc (right): https://codereview.chromium.org/1206673006/diff/1/services/asset_bundle/main.cc#newcode20 services/asset_bundle/main.cc:20: // TODO(vtl): What's the "right" way to choose the ...
5 years, 6 months ago (2015-06-24 22:19:08 UTC) #5
viettrungluu
Thanks Eric & George. https://codereview.chromium.org/1206673006/diff/1/services/asset_bundle/main.cc File services/asset_bundle/main.cc (right): https://codereview.chromium.org/1206673006/diff/1/services/asset_bundle/main.cc#newcode20 services/asset_bundle/main.cc:20: // TODO(vtl): What's the "right" ...
5 years, 6 months ago (2015-06-24 22:23:43 UTC) #6
viettrungluu
Committed patchset #2 (id:20001) manually as 08c72e1bad0fdaa71bb356749bb9b548ac18a174 (presubmit successful).
5 years, 6 months ago (2015-06-24 22:24:08 UTC) #7
abarth-chromium
5 years, 6 months ago (2015-06-24 23:53:55 UTC) #8
Message was sent while issue was closed.
Thanks!

Powered by Google App Engine
This is Rietveld 408576698