components/history/core/test/history_client_fake_bookmarks.cc - Issue 1205603002: Remove dependency of HistoryServiceFactory on ChromeBookmarkClientFactory

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/history/core/test/history_client_fake_bookmarks.cc

Issue 1205603002: Remove dependency of HistoryServiceFactory on ChromeBookmarkClientFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@split_history_client

Patch Set: Fix unit_tests on android (only register as BookmarkModelObserver if HistoryService is initialized) Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: components/history/core/test/history_client_fake_bookmarks.cc

diff --git a/components/history/core/test/history_client_fake_bookmarks.cc b/components/history/core/test/history_client_fake_bookmarks.cc

index 687444299761f9383c0fcc76b3773dc469ab6bae..ceed15fc8e94ab312134811b63ad94c7cdfa606b 100644

--- a/components/history/core/test/history_client_fake_bookmarks.cc

+++ b/components/history/core/test/history_client_fake_bookmarks.cc

@@ -159,6 +159,10 @@ bool HistoryClientFakeBookmarks::IsBookmarked(const GURL& url) {

return bookmarks_->IsBookmarked(url);

}

+void HistoryClientFakeBookmarks::OnHistoryServiceCreated(

+ HistoryService* history_service) {

void HistoryClientFakeBookmarks::Shutdown() {

}

« no previous file with comments | « components/history/core/test/history_client_fake_bookmarks.h ('k') | no next file » | no next file with comments »