Source/core/html/canvas/WebGL2RenderingContextBase.h - Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/canvas/WebGL2RenderingContextBase.h

Issue 1205573003: WebGL 2: validate read buffer attachment when reading from FBO (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: addressed zmo@'s feedback: readbuffer is per framebuffer, not per rendering context Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/html/canvas/WebGL2RenderingContextBase.h

diff --git a/Source/core/html/canvas/WebGL2RenderingContextBase.h b/Source/core/html/canvas/WebGL2RenderingContextBase.h

index c07a719a6610de5de29ecd18a3ec2e84e69d3719..c6241646a7a5f870fc4748e06dc214f4c856888c 100644

--- a/Source/core/html/canvas/WebGL2RenderingContextBase.h

+++ b/Source/core/html/canvas/WebGL2RenderingContextBase.h

@@ -211,6 +211,8 @@ protected:

GLint m_max3DTextureSize;

GLint m_max3DTextureLevel;

+ GLenum m_readBuffer;

RefPtrWillBeMember<WebGLBuffer> m_boundCopyReadBuffer;

RefPtrWillBeMember<WebGLBuffer> m_boundCopyWriteBuffer;

RefPtrWillBeMember<WebGLBuffer> m_boundPixelPackBuffer;

« no previous file with comments | « no previous file | Source/core/html/canvas/WebGL2RenderingContextBase.cpp » ('j') | Source/core/html/canvas/WebGL2RenderingContextBase.cpp » ('J')