Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(690)

Issue 1205423003: Convert gcm_unit_tests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@8_sql_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert gcm_unit_tests to run exclusively on Swarming 0 configs already ran on Swarming 28 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert gcm_unit_tests R=dimich@chromium.org,dpranke@chromium.org TBR= BUG=98637 Committed: https://crrev.com/846bf81ffaed904d0e258a814c6e9ce23d31ee19 Cr-Commit-Position: refs/heads/master@{#336895}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix path #

Patch Set 4 : fix typo #

Patch Set 5 : Fix path typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+109 lines, -5 lines) Patch
M build/gn_migration.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M google_apis/gcm/gcm.gyp View 1 2 3 1 chunk +19 lines, -0 lines 0 comments Download
A + google_apis/gcm/gcm_unit_tests.isolate View 1 2 3 4 2 chunks +5 lines, -5 lines 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (2 generated)
M-A Ruel
5 years, 5 months ago (2015-06-30 19:15:30 UTC) #1
Marc-Antoine Ruel (Google)
TBR'ing since it's a fairly mechanical change.
5 years, 5 months ago (2015-06-30 21:49:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1205423003/80001
5 years, 5 months ago (2015-06-30 21:51:03 UTC) #4
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-06-30 22:30:07 UTC) #5
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/846bf81ffaed904d0e258a814c6e9ce23d31ee19 Cr-Commit-Position: refs/heads/master@{#336895}
5 years, 5 months ago (2015-06-30 22:30:53 UTC) #6
Dirk Pranke
lgtm
5 years, 5 months ago (2015-07-01 19:27:48 UTC) #7
Dmitry Titov
+JianLi
5 years, 5 months ago (2015-07-06 18:44:09 UTC) #9
jianli
5 years, 5 months ago (2015-07-06 21:18:08 UTC) #10
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698