Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 1218143002: Convert sync_unit_tests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
CC:
chromium-reviews, tim+watch_chromium.org, zea+watch_chromium.org, maxbogue+watch_chromium.org, pvalenzuela+watch_chromium.org, plaree+watch_chromium.org, maniscalco+watch_chromium.org
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@9_gcm_unit_tests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert sync_unit_tests to run exclusively on Swarming 0 configs already ran on Swarming 29 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert sync_unit_tests R=dpranke@chromium.org,maniscalco@chromium.org TBR= BUG=98637 Committed: https://crrev.com/03648b0f71a13a54097161d89d2c8fb988112f0e Cr-Commit-Position: refs/heads/master@{#336905}

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : Fix gn_migration.gypi #

Patch Set 4 : Add more dependencies #

Patch Set 5 : Add chrome/test/data/sync, remove sync/tools/testserver/ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+129 lines, -1 line) Patch
M build/gn_migration.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M sync/sync_tests.gypi View 1 chunk +17 lines, -0 lines 0 comments Download
M sync/sync_unit_tests.isolate View 1 2 3 4 1 chunk +24 lines, -1 line 0 comments Download
M testing/buildbot/chromium.chromiumos.json View 1 2 3 4 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 1 2 3 4 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 1 2 3 4 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 1 2 3 4 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 1 2 3 4 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 11 (3 generated)
M-A Ruel
5 years, 5 months ago (2015-06-30 19:21:27 UTC) #1
pval...(no longer on Chromium)
lgtm I'll let maniscalco@ do the rubber-stamp LGTM for the sync/ dir
5 years, 5 months ago (2015-06-30 19:44:17 UTC) #3
maniscalco
sync/ lgtm
5 years, 5 months ago (2015-06-30 19:45:38 UTC) #4
Marc-Antoine Ruel (Google)
TBR'ing testing/buildbot/ part since it's a mechanical change.
5 years, 5 months ago (2015-06-30 21:58:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1218143002/80001
5 years, 5 months ago (2015-06-30 22:00:21 UTC) #8
commit-bot: I haz the power
Committed patchset #5 (id:80001)
5 years, 5 months ago (2015-06-30 23:08:20 UTC) #9
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/03648b0f71a13a54097161d89d2c8fb988112f0e Cr-Commit-Position: refs/heads/master@{#336905}
5 years, 5 months ago (2015-06-30 23:10:28 UTC) #10
Dirk Pranke
5 years, 5 months ago (2015-07-01 19:36:43 UTC) #11
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698