Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(229)

Issue 1217173004: Convert sql_unittests to run exclusively on Swarming (Closed)

Created:
5 years, 5 months ago by M-A Ruel
Modified:
5 years, 5 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/a/chromium/src.git@7_cacheinvalidation_unittests
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert sql_unittests to run exclusively on Swarming 0 configs already ran on Swarming 29 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.win.json: Vista Tests (1) - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) - chromium.win.json: XP Tests (1) Ran: ./manage.py --convert sql_unittests R=gbillock@chromium.org,dpranke@chromium.org TBR= BUG=98637 Committed: https://crrev.com/dd228cfaec87f98fcca1a594bd99a65b5b657d27 Cr-Commit-Position: refs/heads/master@{#336884}

Patch Set 1 #

Patch Set 2 : Fix android #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+105 lines, -1 line) Patch
M sql/sql_unittests.isolate View 1 2 chunks +18 lines, -1 line 1 comment Download
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 5 chunks +15 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 2 chunks +6 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 5 chunks +15 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 7 (1 generated)
M-A Ruel
5 years, 5 months ago (2015-06-30 19:07:48 UTC) #1
Marc-Antoine Ruel (Google)
TBR'ing since it's a fairly mechanical change.
5 years, 5 months ago (2015-06-30 21:46:18 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1217173004/20001
5 years, 5 months ago (2015-06-30 21:48:36 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 5 months ago (2015-06-30 21:55:47 UTC) #5
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/dd228cfaec87f98fcca1a594bd99a65b5b657d27 Cr-Commit-Position: refs/heads/master@{#336884}
5 years, 5 months ago (2015-06-30 21:56:46 UTC) #6
Dirk Pranke
5 years, 5 months ago (2015-07-01 19:26:14 UTC) #7
Message was sent while issue was closed.
lgtm

https://codereview.chromium.org/1217173004/diff/20001/sql/sql_unittests.isolate
File sql/sql_unittests.isolate (right):

https://codereview.chromium.org/1217173004/diff/20001/sql/sql_unittests.isola...
sql/sql_unittests.isolate:1: # Copyright 2015 The Chromium Authors. All rights
reserved.
nit: why did you update the copyright?

Powered by Google App Engine
This is Rietveld 408576698