Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 120513004: Don't expose DocumentWriter to embedding layer (Closed)

Created:
6 years, 11 months ago by Nate Chapin
Modified:
6 years, 11 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, krit, caseq+blink_chromium.org, Nate Chapin, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, gavinp+loader_chromium.org, devtools-reviews_chromium.org, pdr, f(malita), Stephen Chennney, aandrey+blink_chromium.org, rwlbuis
Visibility:
Public.

Description

Don't expose DocumentWriter to embedding layer Currently, several classes that need to build up a fake frame do so by getting direct access to a DocumentWriter and sending the document contents directly into the parsing system. This works, but it looks like a terrible layering violation, particularly since it involves reusing whatever DocumentLoader happens to be the committed DocumentLoader (generally the DocumentLoader for the initial empty document). This patch re-routes these cases to use SubstituteData and go through the normal FrameLoader::load() codepath. This involves re-introducing the concept of a SubstituteData load that is forced to be synchronous, but that seems like less of a hack than the current system. BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164624

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Total comments: 3

Patch Set 5 : #

Patch Set 6 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+175 lines, -207 lines) Patch
M Source/core/fetch/Resource.h View 1 2 3 4 2 chunks +4 lines, -0 lines 0 comments Download
M Source/core/fetch/Resource.cpp View 1 2 3 4 2 chunks +2 lines, -1 line 0 comments Download
M Source/core/fetch/ResourceFetcher.cpp View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M Source/core/inspector/InspectorOverlay.cpp View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M Source/core/loader/DocumentLoader.h View 1 2 3 4 2 chunks +1 line, -4 lines 0 comments Download
M Source/core/loader/DocumentLoader.cpp View 1 2 3 4 6 chunks +4 lines, -33 lines 0 comments Download
M Source/core/loader/SubstituteData.h View 1 2 3 4 1 chunk +32 lines, -21 lines 0 comments Download
M Source/core/page/PagePopupClient.h View 2 chunks +13 lines, -14 lines 0 comments Download
M Source/core/page/PagePopupClient.cpp View 2 chunks +40 lines, -40 lines 0 comments Download
M Source/core/svg/graphics/SVGImage.cpp View 1 2 2 chunks +2 lines, -5 lines 0 comments Download
M Source/core/testing/MockPagePopupDriver.cpp View 1 2 2 chunks +4 lines, -7 lines 0 comments Download
M Source/web/ColorChooserPopupUIController.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/ColorChooserPopupUIController.cpp View 1 2 chunks +12 lines, -12 lines 0 comments Download
M Source/web/DateTimeChooserImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/DateTimeChooserImpl.cpp View 3 chunks +37 lines, -37 lines 0 comments Download
M Source/web/WebHelperPluginImpl.cpp View 1 2 3 3 chunks +10 lines, -21 lines 0 comments Download
M Source/web/WebPagePopupImpl.cpp View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M Source/web/tests/WebViewTest.cpp View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nate Chapin
https://codereview.chromium.org/120513004/diff/290001/Source/core/loader/DocumentLoader.cpp File Source/core/loader/DocumentLoader.cpp (left): https://codereview.chromium.org/120513004/diff/290001/Source/core/loader/DocumentLoader.cpp#oldcode174 Source/core/loader/DocumentLoader.cpp:174: ASSERT(!m_committed); This ASSERT and resetting of m_committed are not ...
6 years, 11 months ago (2014-01-06 21:13:21 UTC) #1
abarth-chromium
lgtm Nice! https://codereview.chromium.org/120513004/diff/290001/Source/core/loader/SubstituteData.h File Source/core/loader/SubstituteData.h (right): https://codereview.chromium.org/120513004/diff/290001/Source/core/loader/SubstituteData.h#newcode35 Source/core/loader/SubstituteData.h:35: enum SubstituteDataLoadPolicy { We usually have a ...
6 years, 11 months ago (2014-01-06 22:29:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/120513004/390001
6 years, 11 months ago (2014-01-07 19:11:29 UTC) #3
commit-bot: I haz the power
Retried try job too often on linux_blink for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink&number=6605
6 years, 11 months ago (2014-01-07 20:06:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/japhet@chromium.org/120513004/540001
6 years, 11 months ago (2014-01-07 20:28:49 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-07 22:41:08 UTC) #6
Message was sent while issue was closed. 
Change committed as 164624

Powered by Google App Engine
This is Rietveld 408576698