Don't expose DocumentWriter to embedding layer

Source/core/loader/SubstituteData.h

 /*
  * Copyright (C) 2007 Apple Inc.  All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 14 matching lines @@
 
 #ifndef SubstituteData_h
 #define SubstituteData_h
 
 #include "platform/SharedBuffer.h"
 #include "platform/weborigin/KURL.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefPtr.h"
 
 namespace WebCore {
+enum SubstituteDataLoadPolicy {

[abarth-chromium, 2014/01/06 22:29:31]

We usually have a blank line above these sorts of declarations.

+    LoadNormally,
+    ForceSynchronousLoad
+};
 
-    class SubstituteData {
-    public:
-        SubstituteData() { }
+class SubstituteData {
+public:
+    SubstituteData()
+        : m_substituteDataLoadPolicy(LoadNormally)
+    {
+    }
 
-        SubstituteData(PassRefPtr<SharedBuffer> content, const AtomicString& mimeType, const AtomicString& textEncoding, const KURL& failingURL)
-            : m_content(content)
-            , m_mimeType(mimeType)
-            , m_textEncoding(textEncoding)
-            , m_failingURL(failingURL)
-        {
-        }
+    SubstituteData(PassRefPtr<SharedBuffer> content, const AtomicString& mimeType, const AtomicString& textEncoding, const KURL& failingURL, SubstituteDataLoadPolicy substituteDataLoadPolicy = LoadNormally)
+        : m_content(content)
+        , m_mimeType(mimeType)
+        , m_textEncoding(textEncoding)
+        , m_failingURL(failingURL)
+        , m_substituteDataLoadPolicy(substituteDataLoadPolicy)
+    {
+    }
 
-        bool isValid() const { return m_content != 0; }
+    bool isValid() const { return m_content; }
 
-        SharedBuffer* content() const { return m_content.get(); }
-        const AtomicString& mimeType() const { return m_mimeType; }
-        const AtomicString& textEncoding() const { return m_textEncoding; }
-        const KURL& failingURL() const { return m_failingURL; }
+    SharedBuffer* content() const { return m_content.get(); }
+    const AtomicString& mimeType() const { return m_mimeType; }
+    const AtomicString& textEncoding() const { return m_textEncoding; }
+    const KURL& failingURL() const { return m_failingURL; }
+    bool forceSynchronousLoad() const { return m_substituteDataLoadPolicy == ForceSynchronousLoad; }

[abarth-chromium, 2014/01/06 22:29:31]

This sounds a bit like a verb...  I think it's ok though.

 
-    private:
-        RefPtr<SharedBuffer> m_content;
-        AtomicString m_mimeType;
-        AtomicString m_textEncoding;
-        KURL m_failingURL;
-    };
+private:
+    RefPtr<SharedBuffer> m_content;
+    AtomicString m_mimeType;
+    AtomicString m_textEncoding;
+    KURL m_failingURL;
+    SubstituteDataLoadPolicy m_substituteDataLoadPolicy;
+};
 
 }
 
 #endif // SubstituteData_h